[dev] [commits] Horde branch master updated. 275b9c579ef363227ec8d024975f02c70d33c8a5

[Michael J Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
>>>
>>>> The branch "master" has been updated.
>>>> The following is a summary of the commits.
>>>>
>>>> from: 25906b6e43200719eabf42dd606524b1c7bc7393
>>>>
>>>> 275b9c5 This makes much more sense as a default.
>>>>
>>>> Summary:  
>>>> http://github.com/horde/horde/compare/25906b6e43200719eabf42dd606524b1c7bc7393...275b9c579ef363227ec8d024975f02c70d33c8a5
>>>>
>>>> -----------------------------------------------------------------------
>>>>
>>>> commit 275b9c579ef363227ec8d024975f02c70d33c8a5
>>>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>>>> Date:   Fri Apr 25 15:53:53 2014 -0400
>>>>
>>>>  This makes much more sense as a default.
>>>>
>>>> horde/config/prefs.php |    2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> http://github.com/horde/horde/commit/275b9c579ef363227ec8d024975f02c70d33c8a5
>>>
>>> That's not going to work.  Chicken/egg problem - you can't grab  
>>> the value of a preference from within the file used to initialize  
>>> the preference value.
>>>
>>> To set a default prefs value dependent on another prefs value you  
>>> have to use something like the prefs_init hook.
>>
>> I half thought that might be the case, but when I tested it, it  
>> successfully set the default. Perhaps it was just the specifics of  
>> how I tested?
>
> It could depend on the order the prefs are stored in prefs.php.  But  
> can't guarantee that order.  (Or else the default identity happens  
> to be 0, and getValue() is returning an empty-ish value).
>
> michael
>

In my case, the default is actually 2, so it's most likely the order.  
Either way, you're right of course. I'll hook it.

-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5849 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20140425/c59b77ed/attachment.bin>