[dev] Is "return true" the sane fallback for hasAppPermission?

Michael M Slusarz slusarz at horde.org
Mon Jul 21 19:48:09 UTC 2014


Quoting Ralf Lang <lang at b1-systems.de>:

> On 21.07.2014 11:35, Jasper Olbrich wrote:
>> Hi,
>>
>> I just stumbled upon the function hasAppPermission in Horde/Core/Perms.php:
>>
>>     if ($this->_perms->exists($app . ':' . $permission)) {
>>         // determine permission
>>     }
>>     return true;
>>
>> Is this "return true;" intentional? In our case, this made everyone
>> "Resource Manager" in Kronolith untill we created the corresponding
>> permission and set it up appropriately.
>>
>
> OTOH, it would deny all users all apps (including horde itself) before
> permissions are configured.

And permissions is an optional feature.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list