[dev] [commits] Horde branch master updated. 7fb00276bde050f0d815a9a4fcea4d55834defa7

[Michael J Rubinsky]

Quoting Jan Schneider <jan at horde.org>:

> commit e7d135f1e9e5d720bc1b369d49909866a323a632
> Author: Jan Schneider <jan at horde.org>
> Date:   Fri Apr 17 09:26:15 2015 +0200
>
>     Use Horde_String's locale-independent methods.
>
>     There are still bundled libraries that use locale-dependent  
> methods, but I
>     won't bother fixing those now. It would be a PITA to keep them  
> patched/updated,
>     and it should rather be fixed upstream anyway.
>
>  framework/ActiveSync/lib/Horde/ActiveSync.php                     |    6 +-
>  framework/ActiveSync/lib/Horde/ActiveSync/Device.php              |   10 +-
>  framework/ActiveSync/lib/Horde/ActiveSync/Imap/Adapter.php        |   12 +-
>  .../ActiveSync/lib/Horde/ActiveSync/Request/ItemOperations.php    |    2 +-
>  framework/ActiveSync/lib/Horde/ActiveSync/Request/Search.php      |    6 +-
>  framework/ActiveSync/test/Horde/ActiveSync/DeviceTest.php         |

Why do we need to use locale-dependent methods on data that is  
guaranteed to be ASCII? I purposely didn't use it on e.g., the device  
id since it will never be 8bit and I thought it would be more  
efficient not to call the extra method.

-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5869 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/dev/attachments/20150420/493490ed/attachment.bin>