[dev] components app converted to PSR-4 (mostly) - want feedback

[Jan Schneider]

Zitat von Ralf Lang <lang at b1-systems.de>:

> Update,
>
>
>> I'd like to merge this once I have fixed Horde_Test and components'
> test suite.
>
>>     Unit tests have not yet been touched and most likely are broken.
>>     This needs a PSR-4 aware Horde_Test to make work.
>
>> I think this should be improved until the qc command can run
> component's own unit tests before merging.
>
> I have fixed most unit tests [when run from the qc unit command]. One or
> two cases I have disabled as an intended failure won't happen due to new
> functionality. Components can now identify a component from almost any
> of its internal paths, not just from the base dir.
>
> Three tests remain failing. Two are version tests where the fixture
> expects a certain version and the code returns one bugfix (3rd digit)
> version later. I have not fully understood the intention of the test and
> if it expresses a real broken behaviour or just a mismatch with the fixture.
>
> One test fails because the composer.json file returned is exactly as
> expected from the fixture, but with today's date rather than some 2010
> date string. Either there is some broken "pretend" behaviour or the test
> is just wrong.
>
> Tests have been moved to the root of the test/ dir but have not yet been
> converted to namespaces. Also, AllTests.php & friends are not yet fixed.
>
> I also did not yet unbundle the bundled dependencies. I think this must
> be done one by one, each time deciding if it's needed to be conservative
> or upgrade to recent versions.

Yes, agreed.

> Also, somewhere we use phpunit-token-stream which is abandoned. I have
> not yet identified where it's actually needed and how we best replace it.

I'm pretty sure this is a sub-dependency.

-- 
Jan Schneider
The Horde Project
https://www.horde.org/