Horde CVS: Problem in lib/Horde.lib

Barry Flanagan barryf-imp at digiserve.ie
Thu Nov 29 04:43:35 PST 2001


On line 285, a recent change made to address my wish to have the port problem sorted out, the line reads:

    if (($registry->getParam('server_port') != 80) && ($registry->getParam('server_port') != 443))

Which is ALWAYS going to be true, because the port can't be both 80 AND 443 - surely this should be || or?

In any event, even changing it to ||, and making server_port => 80 in the Registry, the $server seems to always 
have the  :port appended - works but is ugly in the URL and is un-necessary. Can't figure out why it is appearing.

Also, this leaves no room for someone switching between HTTPS and HTTP, as the server_port is now hardcoded.


-- 

-Barry Flanagan




More information about the horde mailing list