Horde CVS: Error in lib/Horde.lib line 289

[Barry Flanagan]

Still on the subject ot the $server_port and Horde::url

Horde.lib, line 289 should, I think, read 

if (($server_port != 80 && $server_port != 443))

rather than 

if (($server_port != 80) || ($server_port != 443))

as is there at present, which basically always evals to true.

-- 

-Barry Flanagan


>From chuck at horde.org Date: Mon,  3 Dec 2001 11:44:14 -0500
Return-Path: <chuck at horde.org>
Mailing-List: contact horde-help at lists.horde.org; run by ezmlm
Delivered-To: mailing list horde at lists.horde.org
Received: (qmail 64109 invoked from network); 3 Dec 2001 16:44:54 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.196.127)
  by clark.horde.org with SMTP; 3 Dec 2001 16:44:54 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 2467539EB; Mon,  3 Dec 2001 11:44:15 -0500 (EST)
Received: from 192.168.0.115 ( [192.168.0.115])
	as user chuck at localhost by marina.horde.org with HTTP;
	Mon,  3 Dec 2001 11:44:14 -0500
Message-ID: <1007397854.3c0babdeeaff0 at marina.horde.org>
Date: Mon,  3 Dec 2001 11:44:14 -0500
From: Chuck Hagenbuch <chuck at horde.org>
To: horde at lists.horde.org
References: <20011203155316.64360D4283 at bouncer.digiserve.ie>
In-Reply-To: <20011203155316.64360D4283 at bouncer.digiserve.ie>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [horde] Horde CVS: Error in lib/Horde.lib line 289

Quoting Barry Flanagan <barryf-imp at digiserve.ie>:

> Still on the subject ot the $server_port and Horde::url
> 
> Horde.lib, line 289 should, I think, read 

Are you talking about lib/Horde.php? Horde HEAD? Or RELENG_2? Or a tarball?

> if (($server_port != 80 && $server_port != 443))
> 
> rather than 
> 
> if (($server_port != 80) || ($server_port != 443))
> 
> as is there at present, which basically always evals to true.
> 
> -- 
> 
> -Barry Flanagan
> 
> -- 
> Horde mailing list: http://horde.org/horde/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: horde-unsubscribe at lists.horde.org
> 
> 


-chuck

--
Charles Hagenbuch, <chuck at horde.org>
"What was and what may be, lie, like children whose faces we cannot see, in the
arms of silence. All we ever have is here, now." - Ursula K. Le Guin