[horde] Ingo: problem with error handling while adding/modifying a rule

[Gilbert, Marie-Christine]

I think there's a problem with the notification handling for the
modification/add of a rule in Ingo.

The user won't see the error message if an error occurs while creating a
sieve script.

We have looked at the code and we maybe have found something in
ingo/rules.php.
In the swicth($actionId) case INGO_RULE_UPDATE, a call to
Ingo::updateScript() is made. After that, the following instruction is
executed: header('Location: ' . Horde::applicationUrl('filters.php'));

At the end of rules.php, there is a call to $notification->notify();

It seems that this last call($notification->notify()) flushes the
notification's stack before the loading of filters.php. Therefore, the user
won't see the notifications on the filters.php page.

To validate my point, I have added a return statement before the call to
($notification->notify()) and it seems to fixed the problem.

Is someone aware of that problem?

Thanks a lot,

Marie-Christine