[horde] Bug in CVS head sieve INGO module

[Paul Wagland]

Hmm. It appears that IMP likes to eat my messages... it just ate half 
of it again :-\

Anyway, what you saw was a patch to ingo/lib/Script/sieve.php which 
fixes a bug
in the INGO "ends with" matching. Here it is again:

diff -u -r1.60 sieve.php
--- ingo/lib/Script/sieve.php   12 Apr 2004 21:46:50 -0000      1.60
+++ ingo/lib/Script/sieve.php   13 May 2004 01:02:25 -0000
@@ -601,10 +601,10 @@
                      case 'ends with':
                          $vals['match-type'] = ':matches';
                          if ($use_address_test){
-                            $vals['addresses'] .= '*';
+                            $vals['addresses'] = '*' . 
$vals['addresses'];
                              $tmp = &new Sieve_Test_Address($vals);
                          } else {
-                            $vals['strings'] .= '*';
+                            $vals['strings'] = '*' . $vals['strings'];
                              $tmp = &new Sieve_Test_Header($vals);
                          }
                          $test->addTest($tmp);
@@ -613,10 +613,10 @@
                      case 'not ends with':
                          $vals['match-type'] = ':matches';
                          if ($use_address_test){
-                            $vals['addresses'] .= '*';
+                            $vals['addresses'] = '*' . 
$vals['addresses'];
                              $tmp = &new Sieve_Test_Address($vals);
                          } else {
-                            $vals['strings'] .= '*';
+                            $vals['strings'] = '*' . $vals['strings'];
                              $tmp = &new Sieve_Test_Header($vals);
                          }
                          $test->addTest(new Sieve_Test_Not($tmp));

----- Message from paul at kungfoocoder.org ---------    Date: Thu, 13 May 
2004
03:06:08 +0200    From: Paul Wagland <paul at kungfoocoder.org>Reply-To: 
Paul
Wagland <paul at kungfoocoder.org> Subject: Bug in CVS head sieve INGO 
module
To: horde at lists.horde.org

> ['match-type'] = ':matches';
>                          if ($use_address_test){
> -                            $vals['addresses'] .= '*';
> +                            $vals['addresses'] = '*' . 
> $vals['addresses'];
>                              $tmp = &new Sieve_Test_Address($vals);
>                          } else {
> -                            $vals['strings'] .= '*';
> +                            $vals['strings'] = '*' . $vals['strings'];
>                              $tmp = &new Sieve_Test_Header($vals);
>                          }
>                          $test->addTest($tmp);
> @@ -613,10 +613,10 @@
>                      case 'not ends with':
>                          $vals['match-type'] = ':matches';
>                          if ($use_address_test){
> -                            $vals['addresses'] .= '*';
> +                            $vals['addresses'] = '*' . 
> $vals['addresses'];
>                              $tmp = &new Sieve_Test_Address($vals);
>                          } else {
> -                            $vals['strings'] .= '*';
> +                            $vals['strings'] = '*' . $vals['strings'];
>                              $tmp = &new Sieve_Test_Header($vals);
>                          }
>                          $test->addTest(new Sieve_Test_Not($tmp));


----- End message from paul at kungfoocoder.org -----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : http://lists.horde.org/archives/horde/attachments/20040513/b3e75b9c/PGP-0002.bin