[horde] Horde 3.3.7, 3.3.8 patch releases differ from tar.gz releases

[Thomas Jacob]

> Both are official. the patch is *not* created from the release tarballs.

I don't seem to be understanding the idea behind the patch files then. 
I would have assumed that applying the patches is supposed to provide the same
fixes as installing the source and merging your configs and local
changes with it. Is it explained somewhere on the web site?

For instance, what's the point of file patch-horde-3.3.7-3.3.8.gz? As far
as I can tell, no functional code is changed:

$ zcat patch-horde-3.3.7-3.3.8.gz
diff -uNr horde-3.3.7/docs/CHANGES horde-3.3.8/docs/CHANGES
--- horde-3.3.7/docs/CHANGES    2010-04-27 11:56:21.000000000 +0200
+++ horde-3.3.8/docs/CHANGES    2010-04-28 15:30:00.000000000 +0200
@@ -1,4 +1,11 @@
 ------
+v3.3.8
+------
+
+[jan] Fix framework include path.
+
+
+------
 v3.3.7
 ------

diff -uNr horde-3.3.7/docs/RELEASE_NOTES horde-3.3.8/docs/RELEASE_NOTES
--- horde-3.3.7/docs/RELEASE_NOTES      2010-04-27 11:56:21.000000000 +0200
+++ horde-3.3.8/docs/RELEASE_NOTES      2010-04-28 15:25:25.000000000 +0200
@@ -10,18 +10,21 @@
  * Horde_Release::FOCUS_MAJORSECURITY - Major security fixes
  * Horde_Release::FOCUS_DOCS - Documentation improvements
  */
-$this->notes['fm']['focus'] = array(Horde_Release::FOCUS_MINORBUG);
+$this->notes['fm']['focus'] = array(Horde_Release::FOCUS_MAJORBUG);

 /* Mailing list release notes. */
 $this->notes['ml']['changes'] = <<<ML
 The Horde Team is pleased to announce the final release of the Horde
-Application Framework version 3.3.7.
+Application Framework version 3.3.8.

 The Horde Application Framework is a modular, general-purpose web application
 framework written in PHP.  It provides an extensive array of classes that are
 targeted at the common problems and tasks involved in developing modern web
 applications.

+The major changes compared to Horde version 3.3.7 are:
+    * Fixed a regression with a wrong include path.
+
 The major changes compared to Horde version 3.3.6 are:
     * Synchronization improvements.
     * Multiple other small bug fixes and improvements.
@@ -29,8 +32,7 @@

 /* Freshmeat release notes, not more than 600 characters. */
 $this->notes['fm']['changes'] = <<<FM
-Synchronization has been improved.
-Multiple other small bug fixes and improvements have been made.
+A regression with a wrong include path has been fixed.
 FM;

 $this->notes['name'] = 'Horde';
diff -uNr horde-3.3.7/lib/version.php horde-3.3.8/lib/version.php
--- horde-3.3.7/lib/version.php 2010-04-27 17:36:58.000000000 +0200
+++ horde-3.3.8/lib/version.php 2010-04-28 15:39:38.000000000 +0200
@@ -1 +1 @@
-<?php define('HORDE_VERSION', '3.3.7') ?>
+<?php define('HORDE_VERSION', '3.3.8') ?>


The manual diff between 3.3.7 and 3.3.8 produces another
change, presumably the actual fix:

diff -ruN horde-3.3.7/lib/core.php horde-3.3.8/lib/core.php
--- horde-3.3.7/lib/core.php    2010-04-08 10:20:17.000000000 +0200
+++ horde-3.3.8/lib/core.php    2010-04-28 15:39:38.000000000 +0200
@@ -32,7 +32,7 @@
 /* If the Horde Framework packages are not installed in PHP's global
  * include_path, you must add an ini_set() call here to add their location to
  * the include_path. */
-// ini_set('include_path', dirname(__FILE__) . PATH_SEPARATOR . ini_get('include_path'));
+ini_set('include_path', dirname(__FILE__) . PATH_SEPARATOR . ini_get('include_path'));

 /* PEAR base class. */
 include_once 'PEAR.php';


I haven't checked the 3.3.6-7 for any missing code changes yet.