[horde] H4 PGP issues

[Simon Wilson]

Quoting Jan Schneider <jan at horde.org>:
>> Zitat von Simon Wilson <simon at simonandkate.net>:
>   >
>   >>
>   >> First issue - ever since loading the Passphrase, opening the PGP
>   >> prefs page results in an empty sidebar, and IE 8 generating an
>   >> "Error on page" message. Details are:
>   >>
>   >> 'null' is null or not an object
>   >> prefs.php Line 7 Char 416
>   >> Code:0
>   >> URI:https://......../services/prefs.php?app=imp&group=pgp
>   >
>   > And what javascript *is* on that line? Try with a real browser and
>   > see if you can get more information about this script error.
>   >

LOL. Regardless of whether it's a "real" browser, a lot of people use  
it. Including my work PC.

Anyhoo... putting that aside..., disabling cached JS and trying in Chrome:

Uncaught TypeError: Cannot call method 'observe' of null
HordeSidebar.domain        prefs.php:15
responder                  prototype.js:5575
fire                       prototype.js:5734
_methodized                prototype.js:438
fireContentLoadedEvent     prototype.js:5820

prefs.php line 15 is:

document.observe("dom:loaded", function() {Horde.popup_block_text="A  
popup window could not be opened. Your browser may be blocking  
popups.";$("import_pgp_public").observe("click", function(e) {  
void(Horde.popup('%7B%22url%22%3A%22%5C%2Fimp%5C%2Fpgp.php%22%2C%22height%22%3A275%2C%22params%22%3A%22actionID%3Dimport_public_key%26reload%3D_d%25253AIH7CU9JO7vlN063kyNkH-mA%22%2C%22width%22%3A750%7D'));; e.stop(); });$("imp_passphrase_1").observe("click", function(e) { IMPDialog.display('%2F%2A-secure-%7B%22cancel_text%22%3A%22Cancel%22%2C%22ok_text%22%3A%22OK%22%2C%22params%22%3A%7B%22type%22%3A%22pgpPersonal%22%7D%2C%22password%22%3Atrue%2C%22text%22%3A%22Enter%20your%20personal%20PGP%20passphrase.%22%2C%22type%22%3A%22pgpPersonal%22%2C%22uri%22%3A%22%5C%2Fservices%5C%2Fimple.php%3Fimple%3DPassphraseDialog%252FimpleApp%253Dimp%252FsessionWrite%253D1%22%7D%2A%2F');e.stop(); });$("delete_pgp_privkey").observe("click", function(e) { if (!window.confirm("Are you sure you want to delete your keypair? (This is NOT recommended!)")) { e.stop(); } });window.HordeSidebar.tree = new  
Horde_Tree({"extraColsLeft":0,"extraColsRight":0,"header":[],"nocookie":false,"options":{"lines":true,"jsvar":"HordeSidebar.tree","session":{"get":["Horde_Core_Factory_Tree","getSession"],"set":["Horde_Core_Factory_Tree","setSession"]}},"target":"horde_menu","cookieDomain":"h4.simonandkate.net","cookiePath":"\/","imgBlank":"","imgFolder":14,"imgFolderOpen":15,"imgLine":1,"imgJoin":2,"imgJoinBottom":4,"imgJoinTop":3,"imgPlus":10,"imgPlusBottom":11,"imgPlusOnly":12,"imgMinus":6,"imgMinusBottom":7,"imgMinusOnly":8,"imgNullOnly":13,"imgLeaf":16,"initTree":{"is_static":0,"nodes":[],"root_nodes":[]}});});HordeSidebar.domain="h4.simonandkate.net";HordeSidebar.path="\/";HordeSidebar.refresh=300;HordeSidebar.url="\/services\/ajax.php\/horde\/sidebarUpdate";HordeSidebar.width=225;

I have verified that this happens in IE, Chrome, and Firefox. I'll log a bug.

>   >> "Send Key to Public Keyserver" results in the same "...malicious
>   >> request..." error and behaviour.
>   >
>   > http://bugs.horde.org/ticket/10070
>   >

Noted and added to.

-- 
Simon Wilson
M: 0400 12 11 16