[horde] Problem with HTML compose [SOLVED]

[Michael M Slusarz]

Quoting sbasurto at soft-gator.com:

> On Tue, 2013-07-16 at 16:06 -0600, Michael M Slusarz wrote:
>
>> Quoting sbasurto at soft-gator.com:
>>
>> > In the function:
>> >
>> >  protected function _addExternalData($html)
>> >     {
>> >         /* Return immediately if related conversion is turned off via
>> >          * configuration. */
>> >         if (empty($GLOBALS['conf']['compose']['convert_to_related'])) {
>> >             return;
>> >         }
>> > // more code here.
>> >
>> > In my case I have the $GLOBALS['conf']['compose']['convert_to_related']
>> > turned off. So returns with nothing, and in the call the variable
>> > $body_html is equaled to what the function returns, so after the call it
>> > contains nothing.
>>
>> This was fixed looooong ago:
>>
>> -----
>>
>> commit 9f267487cd95c3fae9d9f12b0bb5bff71bab38cd
>> Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
>> Date:   Thu Dec 13 19:26:24 2012 +0100
>>
>>      Fix loss of HTML body if related conversion is turned off
>>
>>      Signed-off-by: Michael M Slusarz <slusarz at horde.org>
>>
>> diff --git a/imp/lib/Compose.php b/imp/lib/Compose.php
>> index 060ed25..853451a 100644
>> --- a/imp/lib/Compose.php
>> +++ b/imp/lib/Compose.php
>> @@ -2556,7 +2556,7 @@ class IMP_Compose implements ArrayAccess,
>> Countable, Iterator, Serializable
>>           /* Return immediately if related conversion is turned off via
>>            * configuration. */
>>           if (empty($GLOBALS['conf']['compose']['convert_to_related'])) {
>> -            return;
>> +            return $html;
>>           }
>>
>>           $client = $GLOBALS['injector']
>>
>> -----
>>
>> michael
>>
>> ___________________________________
>> Michael Slusarz [slusarz at horde.org]
>>
>
> Ok, I did not know about it, why when I post the question no one
> answer?. Some times is hard to find the solutions out there, I search in
> google and never find a solution to the problem. I post the question
> here and nobody answer.
>
> Where is the right place, to find answers for horde?

This happened so long ago, that nobody is going to remember it off-hand.

The most important thing is to never ask a question about a bug  
without first upgrading to the latest release.  This was fixed way  
back in IMP 6.0.3 (there have been an additional 6 releases since then  
also).  You can't be asking about issues in IMP 6.0.2 and expect a  
response.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]