[horde] Modifying files -- best practice?

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> You are correct - this is the only place to change this.  Probably  
>> need to abstract this better in the future with something like a  
>> CSS class name ... although part of me says the reason I did it  
>> this way is because it was not easy to do this via CSS.  (Not  
>> looking at the code at the moment, so can't provide more insight  
>> than that.)
>
> But you can override this in the prefs, so you add some  
> imp/config/prefs.d/ file to your theme pack.

This is a *really* big hack.  I wrote this code, and even I am not  
sure I would be able to tell you how to do this properly.

It would be much easier to simply have a CSS entry for  
".deletedMessageHighlight".  For some reason we directly add the  
background-color hard-coded in the class to the rows and I can't  
remember if there is a technical reason why we do so.  (Regardless,  
this won't change until IMP 7.0 so this is kind of an academic  
exercise right now into future design)

michael

___________________________________
Michael Slusarz [slusarz at horde.org]