[horde] RRULE in .ics file contains wrong timestamp in field UNTIL

[Jan Schneider]

Zitat von Pulz, Joerg <Joerg.Pulz at frm2.tum.de>:

> Hi,
>
> during debugging CalDAV sync problems for recurring events i found  
> the following bug.
>
> The generated .ics file for recurring events contains several RRULE entries.
> Many of those RRULE entries contain a field UNTIL with a timestamp.
> This timestamp should be in the format:
>     YYYYMMDDTHHMMSSZ but in the .ics file it is
>     YYYYMMDDTHHMSSZ.
>
> After digging in the code i found the following 3 times in  
> "framework/Timezone/lib/Horde/Timezone/Rule.php":
>
>                     $until = ';UNTIL=' . $last->format('Ymd\THIs') . 'Z';
>
> This is obviously wrong as "I" (capital i) means "Whether or not the  
> date is in daylight saving time" and is set to "1 if Daylight Saving  
> Time, 0 otherwise". (out of the php documentation)
>
> I changed the 3 lines in the code to this:
>
>                     $until = ';UNTIL=' . $last->format('Ymd\THis') . 'Z';
>
> and everything is working now. CalDAV syncing is working and .ics  
> export shows the correct timestamp.
> Only for clarification: "i" means "Minutes with leading zeros" and  
> is set to "00 to 59". (out of the php documentation)
>
> A complete patch for  
> "framework/Timezone/lib/Horde/Timezone/Rule.php" is attached.
>
> It would be nice if someone could take a look at it and commits the patch.
>
> Kind regards
> Joerg

Committed, thanks!

-- 
Jan Schneider
The Horde Project
http://www.horde.org/
https://www.facebook.com/hordeproject