[horde] New message/reply: Content not loading ... fixed

[Frank Richter]

Hi,

after upgrading to Horde 5.2.2/Imp 6.2.3 a few users had problems with new 
messages/reply in dynamic mode:
The new window opened with "Loading ..." as content, nothing more.
A JavaScript error was recorded in the console (from Google Chrome):

if(!l){l=k.opts.data.find(function(f){return f.v==s;});if(!l){return;}

     Uncaught TypeError: Cannot read property 'find' of undefined
     dd1acc4dc7a4934c3f9cf7174533ec365e9ba0dc.js:283 DimpCompose.setPopdownLabel
     dd1acc4dc7a4934c3f9cf7174533ec365e9ba0dc.js:283 DimpCompose.changeIdentity
     dd1acc4dc7a4934c3f9cf7174533ec365e9ba0dc.js:275 DimpCompose.onDomLoad
     dd1acc4dc7a4934c3f9cf7174533ec365e9ba0dc.js:414 (anonymous function)
     bac726f2b85176b0d0083a0b6368e96d8ad7d8c8.js:738 fireEvent_DOM
     bac726f2b85176b0d0083a0b6368e96d8ad7d8c8.js:726 fire
     bac726f2b85176b0d0083a0b6368e96d8ad7d8c8.js:725 _methodized
     bac726f2b85176b0d0083a0b6368e96d8ad7d8c8.js:65 fireContentLoadedEvent
     bac726f2b85176b0d0083a0b6368e96d8ad7d8c8.js:74

These users had a strange preference in identities regarding 
'sent_mail_folder' - empty string or even boolean false.
After correcting this, the JavaScript error doesn't occur any more, the 
function works. So this is fixed here.

It would be a good thing, if the code could be tolerant with such 
configuration mistakes.
We have a loooong Horde history with preferences many years old ...

Kind Regards,
Frank

-- 
Frank Richter
Technische Universität Chemnitz, Germany

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5416 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.horde.org/archives/horde/attachments/20141110/339fb8cb/attachment.bin>