[horde] themes horde-resources div?

Jan Schneider jan at horde.org
Mon Jan 5 11:09:55 UTC 2015


Zitat von Erling Preben Hansen <erling at eph.dk>:

> Citat af Jan Schneider <jan at horde.org>:
>
>> Zitat von Erling Preben Hansen <erling at eph.dk>:
>>
>>> Citat af Jan Schneider <jan at horde.org>:
>>>
>>>> Zitat von Erling Preben Hansen <erling at eph.dk>:
>>>>
>>>>> Citat af Michael M Slusarz <slusarz at horde.org>:
>>>>>
>>>>>> Quoting Erling Preben Hansen <erling at eph.dk>:
>>>>>>
>>>>>>> Hey
>>>>>>> And a happy new year to all of you.
>>>>>>>
>>>>>>> I am updating and improving my Horde themes to 5.2
>>>>>>>
>>>>>>> In turba and mnemos sidebar.
>>>>>>> I can't change the background color of the div for users default
>>>>>>> addressbook and notebook.
>>>>>>>
>>>>>>> I can change most of it, but not the color around the "edit" icon.
>>>>>>>
>>>>>>> Why How?
>>>>>>>
>>>>>>> -----
>>>>>>> Inspecting in firefox or chrome
>>>>>>>
>>>>>>>     <div class="horde-resources">
>>>>>>> -----> <div class="" style="color: rgb(0, 0, 0); background-color:
>>>>>>> rgb(221,
>>>>>>> 221, 221);"> <-------------
>>>>>>>             <a class="horde-resource-edit-000"
>>>>>
>>>>> title="Rediger"
>>>>>>> href="/horde/turba/addressbooks/edit.php?a=xxxxxxxxxxxxxxxx"></a>
>>>>>>>             <div class="horde-resource-link">
>>>>>>>                 <a class="horde-resource-on
>>>>>
>>>>> horde-radiobox"
>>>>>>> href="/horde/turba/?source=xxxxxxxxxxxxxxxxxxx"></a>
>>>>>>>             </div>
>>>>>>>         </div>
>>>>>>>     </div>
>>>>>>>
>>>>>>> element {
>>>>>>>     color: #000;
>>>>>>>     background-color: #DDD;  !this color is said to be inline
>>>>>
>>>>> element.
>>>>>>> I can't find the definition.!
>>>>>>> }
>>>>>>
>>>>>> Horde_View_Sidebar#addRow()
>>>>>>
>>>>>> michael
>>>>>>
>>>>>> ___________________________________
>>>>>> Michael Slusarz [slusarz at horde.org]
>>>>>>
>>>>>> --
>>>>>> Horde mailing list
>>>>>> Frequently Asked Questions: http://horde.org/faq/To unsubscribe,
> mail:
>>>>>> horde-unsubscribe at lists.horde.org
>>>>>
>>>>> Hey
>>>>>
>>>>> It seems like there are no css styles for that div.
>>>>> Therefor default from lib/View/Sidebar.php is in use.
>>>>>
>>>>> Since the color is chosen by user in kronolith and nag.
>>>>> perhaps some css style in turba and mnemo screen.css
>>>>>
>>>>> I don't know exatly how to do this.
>>>>> Can some css dev perhaps look in to this?
>>>>> -------
>>>>> this only changes part of the backgrund-color:
>>>>>
>>>>> #horde-sidebar div.horde-resources div {
>>>>>     background-color: black;
>>>>>     margin: 5px 0;
>>>>> }
>>>>> ----------
>>>>> /erling
>>>>> --
>>>>> Horde mailing list
>>>>> Frequently Asked Questions: http://horde.org/faq/
>>>>> To unsubscribe, mail: horde-unsubscribe at lists.horde.org
>>>>
>>>> The default color for calendars is hardcoded.
>>>>
>>>> --
>>>> Jan Schneider
>>>> The Horde Project
>>>> http://www.horde.org/
>>>> https://www.facebook.com/hordeproject
>>>>
>>>> --
>>>> Horde mailing list
>>>> Frequently Asked Questions: http://horde.org/faq/To unsubscribe, mail:
>>>> horde-unsubscribe at lists.horde.org
>>>
>>> Hey
>>>
>>> To show how what i mean. I have put some pictures in my wiki.
>>>
>>> http://eph.dk/horde/wicked/Themes_error
>>>
>>> /erling
>>> --
>>> Horde mailing list
>>> Frequently Asked Questions: http://horde.org/faq/
>>> To unsubscribe, mail: horde-unsubscribe at lists.horde.org
>>
>> It's still hardcoded.
>>
>> --
>> Jan Schneider
>> The Horde Project
>> http://www.horde.org/
>> https://www.facebook.com/hordeproject
>>
>> --
>> Horde mailing list
>> Frequently Asked Questions: http://horde.org/faq/To unsubscribe, mail:
>> horde-unsubscribe at lists.horde.org
>
> Hey
> A small suggestion.
>
> I have been looking into these hardcoded colors in mnemo and turbas
> sidemenu.
>
> If line 209 in horde/lib/View/Sidebar.php
>
>             if (!isset($row['color'])) {
> 209 ---->   $row['color'] = 'inherit';  /* changed from '#dddddd' */
>             }
>
> and line 148 in mnemo/lib/Application.php
>
> $row = array(
>                 'selected' => in_array($name,
> $GLOBALS['display_notepads']),
>                 'url' => $url,
>                 'label' => Mnemo::getLabel($notepad),
> line148 ------> 'color' => $notepad->get('color') ?: 'inherit',  /*
> changed from '#dddddd' */
>                 'edit' => $edit->add('n',
> $notepad->getName()),
>                 'type' => 'checkbox',
>             );
>
> Is changed from '#dddddd' to 'inherit' the theme colors is visible.
> As far as I can see it don't interfere with anything else.
> But what do I know.
> I am not a programmer.
> But of course it is a small change of the design.
> So it must be a design decision.
>
> /erling
> -- 
> Horde mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: horde-unsubscribe at lists.horde.org

Looks fine, at a first glance.

-- 
Jan Schneider
The Horde Project
http://www.horde.org/
https://www.facebook.com/hordeproject



More information about the horde mailing list