[horde] HTTP 500 with Horde_ActiveSync_Message_Contact->_parseDate('--11-26')

[Michael J Rubinsky]

Quoting Steffen <skhorde at smail.inf.fh-bonn-rhein-sieg.de>:

> An Android client is trying to sync a contact with a birthday without year.
>
> Returning HTTP 500 while handling Sync command. [pid 29889 on line  
> 158 of "/var/www/horde/rpc.php"]
> Error in communicating with ActiveSync server: Invalid date format  
> [pid 29889 on line 162 of "/usr/share/php/Horde/Rpc/ActiveSync.php"]
> #0 /usr/share/php/Horde/ActiveSync/Message/Contact.php(401):  
> Horde_ActiveSync_Message_Base->_parseDate('--11-26')#012#1  
> /usr/share/php/Horde/ActiveSync/Message/Base.php(360):  
> Horde_ActiveSync_Message_Contact->_parseDate('--11-26')#012#2  
> /usr/share/php/Horde/ActiveSync/Request/Sync.php(968):  
> Horde_ActiveSync_Message_Base->decodeStream(Object(Horde_ActiveSync_Wbxml_Decoder))#012#3 /usr/share/php/Horde/ActiveSync/Request/Sync.php(798): Horde_ActiveSync_Request_Sync->_parseSyncCommands(Array)#012#4 /usr/share/php/Horde/ActiveSync/Request/Sync.php(201): Horde_ActiveSync_Request_Sync->_parseSyncFolders()#012#5 /usr/share/php/Horde/ActiveSync/Request/Base.php(253): Horde_ActiveSync_Request_Sync->_handle()#012#6 /usr/share/php/Horde/ActiveSync.php(882): Horde_ActiveSync_Request_Base->handle()#012#7 /usr/share/php/Horde/Rpc/ActiveSync.php(143): Horde_ActiveSync->handleRequest('Sync', 'androidc4589945...')#012#8 /var/www/horde/rpc.php(158):  
> Horde_Rpc_ActiveSync->getResponse(NULL)#012#!
> 9 {main} [pid 29889 on line 162 of "/usr/share/php/Horde/Rpc/ActiveSync.php"]
> Buffer contents:  [pid 29889 on line 162 of  
> "/usr/share/php/Horde/Rpc/ActiveSync.php"]
>
> The ActiveSync log has:
>
> 2015-03-03T10:44:09+01:00 DEBUG: [29889] I        <POOMCONTACTS:Birthday>
> 2015-03-03T10:44:09+01:00 DEBUG: [29889] I          --11-26
> 2015-03-03T10:44:09+01:00 ERR: Invalid date format
>
> Dunno, if the ActiveSync protocol or whatelse is involved, too, does  
> allow a birthday / an anniversary without year.

This is indeed a broken client. That is not a valid date format.  
However, we shouldn't let misbehaving clients destroy the sync, so  
already fixed in Git to ignore the date if it can't be parsed.

-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5869 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/horde/attachments/20150303/ac713bec/attachment.bin>