[horde] a small typo in default theme.

Erling Preben Hansen erling at eph.dk
Thu Jun 4 22:05:58 UTC 2015


  Citat af Jean Charles Delépine <delepine at u-picardie.fr>:

> Quoting Erling Preben Hansen <erling at eph.dk>:
>
>> Hey
>>
>> am working on themes.
>> I found a small but annoying typo in  nag/themes/default/screen.css
>>
>> #RB_window {
>>     top: 50px !important;
>> }
>>
>> it should have been:
>>
>> #RB_window {
>>     top: 50% !important;
>> }
>>
>> Effect is quickadd box in nag is placed too high in browser.
>> The text above input field is not visible.
>
> I have the same problem on a fresh pear install. With nag, not with
> kronolith.
>
> kronolith's screen.css says :
>
> kronolith/themes/default/dynamic/screen.css:/* Redbox styles. */
> kronolith/themes/default/dynamic/screen.css-#RB_window {
> kronolith/themes/default/dynamic/screen.css-    top: 50px !important;
> kronolith/themes/default/dynamic/screen.css-    margin-top: 0
!important;
>
> nag's one says :
>
> nag/themes/default/screen.css:/* Redbox styles. */
> nag/themes/default/screen.css-#RB_window {
> nag/themes/default/screen.css-    top: 50px !important;
> nag/themes/default/screen.css-}
>
> Adding "margin-top: 0 !important;" to nag/themes/default/screen.css
> solve the problem for me.
>
> attached :
>     - patch
>     - screen shot of nag on demo.horde.org
>     - screen shot of kronolith on demo.horde.org
>     - screen shot of corrected nag on demo.horde.org
>
> I was on the way to create a ticket when I find this thread.
>
> Sincerly,
>        Jean Charles Delépine
>
> -----
> Pièces jointes (Les liens expireront le 31/12/2015):
>
> 1. nag_redbox.patch (1 Ko) [text/x-diff]
> Télécharger le lien :
>
https://www.u-picardie.fr/horde/imp/attachment.php?id=55701006-7948-4f4c-904c-5a7b0a008436&u=delepine
>
> 2. nag_RB_window.png (108 Ko) [image/png]
> Télécharger le lien :
>
https://www.u-picardie.fr/horde/imp/attachment.php?id=5570101c-18ec-4964-a68d-688a0a008436&u=delepine
>
> 3. kronolith_RB_window.png (136 Ko) [image/png]
> Télécharger le lien :
>
https://www.u-picardie.fr/horde/imp/attachment.php?id=55701023-545c-420b-8151-21be0a008436&u=delepine
>
> 4. nag_RB_window_patch.png (122 Ko) [image/png]
> Télécharger le lien :
>
https://www.u-picardie.fr/horde/imp/attachment.php?id=55701029-9730-4f10-98f4-21be0a008436&u=delepine
>
> --
> Horde mailing list
> Frequently Asked Questions: http://horde.org/faq/To unsubscribe, mail:
> horde-unsubscribe at lists.horde.org

Hey

A smarter solution could be:

add
    top: 50px !important;
    margin-top: 0px !important;
To:
#RB_window {
    z-index: 102;
    background-color: #fff;
    text-align: left;
}

in horde/themes/default/screen.css  around line 1015

and remove
the lines in
kronolith/themes/default/dynamic/screen.css around line 697
and in
nag/themes/default/screen.css around line 28

This way it will be default for all and one would only need to change it
when / if needed.
In other apps/modules.
As i know it. It is only used in nag and kronolith, as is now.

/erling


More information about the horde mailing list