[horde] Themes issues?

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Dominik Erdmann <horde_mailing at der-domi.de>:
>>
>>> Am 17.06.2015 um 18:13 schrieb Jan Schneider:
>>>
>>>>>> CSS cache ist stored in static/
>>>>>
>>>>> Perfect! I deleted all cache files in static and the browser cache.
>>>>> Now it looks fine again. Thanks!
>>>>>
>>>>> Does make it sense to clear the files in the folders after the
>>>>> lifetime of the specific caching files is expired?
>>>>> CSS and JS cache is stored in static/ and theme cache in
>>>>> $conf[cache][params][dir], correct?
>>>>
>>>> The cache expires automatically, but depending on whether you use a
>>>> release or git installation, you may need to change the css cache  
>>>> settings.
>>>
>>> Okay. The expiration is defined in the lifetime values. But the  
>>> expired cache files will not be deleted automatically, correct?
>>> I wondering why I had to delete the cache to get the correct CSS.  
>>> The issue began a few weeks ago.
>>>
>>> I'm using a git installation. Which settings do you mean? I don't  
>>> see any difference to my PEAR release installation. Here are the  
>>> cache settings of git.
>>
>> [snip]
>>
>>> $conf['cachecss'] = true;
>>> $conf['cachethemes'] = true;
>>
>> This won't work for git, since you are constantly updating the CSS  
>> from source but the version numbers are not changing (so the cache  
>> is not being invalidated).  This is no different than if you were  
>> manually editing CSS files, for example.
>>
>> CSS/Theme caching only works if using release versions or if you  
>> are willing to manually clear the cache.
>
> Not quite. That's what the filemtime setting is for, no?

We don't do filemtime checks.  On purpose.  It can be quite expensive  
across the number of themes/CSS directories needed to be scanned  
(especially if they are on separate remote filesystems).

I believe that was a TODO at some point to add a filemtime option, but  
it doesn't exist currently.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]