[horde] Wrong upgrade notifications

[John H. Bennett III]

Quoting Ferdinand Gruber <fer.grub at yahoo.de>:

> Am 2018-07-05 um 22:38 schrieb Jan Schneider:
>>
>> Zitat von Ferdinand Gruber <fer.grub at yahoo.de>:
>>
>>> Hi,
>>>
>>> on the Administration page of Horde Groupware, I see that there  
>>> are several new modules available, e.g. Horde_ActiveSync
>>>
>>> But after typing in the terminal:
>>>
>>>     pear upgrade horde/Horde_ActiveSync
>>>
>>> I get this message:
>>>
>>>     Nothing to upgrade
>>>
>>> This behaviour occurs with all modules beginning with Horde_ (e.g.  
>>> Horde_ActiveSync, Horde_Auth, Horde_alarm, ... ).
>>
>> You probably have different pear configurations for the webserver  
>> user and the console user.
>>
> Unfortunately I don't know how to handle this. Please can you give me a hint.
>
> -- 
> Regards from Austria
> Ferdinand Gruber
>
> -- 
> Horde mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: horde-unsubscribe at lists.horde.org

I'm seeing this as well on my test and production servers.  I notice a  
difference in horde/admin/config/index.php. horde 5.2.17 there is this:
/* Check for versions if requested. */
$versions = array();
if ($vars->check_versions) {
     $pearConfig = PEAR_Config::singleton();
     $packageFile = new PEAR_PackageFile($pearConfig);
     $packages = array();
     foreach ($pearConfig->getRegistry()->packageInfo(null, null,  
'pear.horde.org') as $package) {
         $packages[$package['name']] = $package['version']['release'];
     }
     foreach (glob(__DIR__ . '/../../../framework/*/package.xml') as  
$packagexml) {
         $package = $packageFile->fromPackageFile($packagexml,  
PEAR_VALIDATE_NORMAL);
         if (!($package instanceof PEAR_Error)) {
             $packages[$package->getName()] = $package->getVersion();
         }
     }

     try {
         $versions = $hconfig->checkVersions();
     } catch (Horde_Exception $e) {
         $notification->push(_("Could not contact server. Try again  
later."), 'horde.error');
     }
}


In 5.2.18:
/* Check for versions if requested. */
$versions = array();
if ($vars->check_versions) {
     $pearConfig = PEAR_Config::singleton();
     $packageFile = new PEAR_PackageFile($pearConfig);
     $packages = array();
     foreach (glob(__DIR__ . '/../../../*/package.xml') as $packagexml) {
         $package = $packageFile->fromPackageFile($packagexml,  
PEAR_VALIDATE_NORMAL);
         if (!($package instanceof PEAR_Error)) {
             $packages[$package->getName()] = $package->getVersion();
         }
     }

     try {
         $versions = $hconfig->checkVersions();
     } catch (Horde_Exception $e) {
         $notification->push(_("Could not contact server. Try again  
later."), 'horde.error');
     }
}

If I copy the 5.2.17 section to the 5.2.18, then this at least fixes  
things on both my systems.

Thank you,

John