[horde] Git Errors since last pull

[Simon B]

On Mon, 7 Nov 2022 at 10:47, Ralf Lang <ralf.lang at ralf-lang.de> wrote:
>
> Hi Simon,
>
> Am 07.11.2022 um 10:30 schrieb Simon B:
>
> Hi,
>
> I do a regular pull of Git on Mondays.  Since today's update, I am getting
> these errors in the logs...
>
> [Mon Nov 07 09:14:17.660451 2022] [:error] [pid 29983] [client
> 217.110.192.38:60062] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:18:42.345592 2022] [:error] [pid 30168] [client
> 217.110.192.38:52688] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:19:15.478257 2022] [:error] [pid 29979] [client
> 217.110.192.38:8685] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:22:26.859395 2022] [:error] [pid 29380] [client
> 2a00:20:59:db40:59a8:50ce:920b:38bd:60850] PHP Parse error:  syntax error,
> unexpected ':', expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:22:27.146689 2022] [:error] [pid 29982] [client
> 2a00:20:59:db40:59a8:50ce:920b:38bd:60851] PHP Parse error:  syntax error,
> unexpected ':', expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:23:20.170378 2022] [:error] [pid 16360] [client
> 217.110.192.38:5194] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:12.667671 2022] [:error] [pid 16363] [client
> 217.110.192.38:53794] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:22.675380 2022] [:error] [pid 16372] [client
> 217.110.192.38:42380] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:22.680569 2022] [:error] [pid 16371] [client
> 217.110.192.38:15488] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
> [Mon Nov 07 09:26:23.162526 2022] [:error] [pid 16360] [client
> 217.110.192.38:18120] PHP Parse error:  syntax error, unexpected ':',
> expecting ';' or '{' in
> /usr/share/2020-git-horde/Cache/lib/Horde/Cache/Storage/Base.php on line 126
>
> How can I roll back?
>
> Thanks.
>
> Simon
>
> I personally don't do git-tools installs anymore.
>
> Can you give the hash value of your current horde/cache checkout and your current PHP version?
>
> cd /usr/share/2020-git-horde/Cache/
> git log --pretty=format:'%h' -n 1
> php --version | head -n 1
>
>
> The immediate remediation would be to checkout a previous commit of horde/cache until you are back to working
>
>
> git log
> ## read up the log to jump 2-3 commits back - copy/paste the commit hash
> ## example
> git checkout 8b392e3d6c7672cdc8edce7d78433872a57b5048

Hi Ralf,

Thanks - your reply landed in spam, so I did not see it before writing:
>
> For anyone else with this issue - the solution is:
>
>  ./horde-git-tools/bin/horde-git-tools git run "reset --hard
> master@{1.days.ago}"
>
> Unfortunately, this also reverted some security fixes,
>
> In essence - and this is not a complaint - the "problem" was with the
> commited updates to better support PHP7+
> (https://github.com/horde/turba/pull/11/commits/40978808ac0b539a523f5696be315d0e255d9adb)
>   I am still running 5.6 because support until now was flakey.
>
> Most of the errors were fixable, but one resultes in IMP is marked as
> authenticated, but no credentials can be found in the session. in
> /Core/lib/Horde/Registry.php:1679 - and that one I could not fix,
> hence the rollback.


> Now looking at the commit log of horde/cache, michael has recently merged code I wrote.
>
> The culprit seems to be:
>
> https://github.com/horde/Cache/commit/46b1affeafa09c1f375c438992b67ab3267aefe3#diff-0e32ec9f22b91acc4a01fedc8dc9c8bd86974aab62da550ba9da52ce7f76a663R126
>
> This return type hint thing was introduced in PHP 7.0 - you are likely running PHP 5.6 or older on that machine. That would be my guess.
>
> See https://caniphp.com/?s=return+type

Would it not have been better to fork the repository? :)


> Regards
>
> Ralf