[horde] Dev on H6 starts again

Sat Apr 12 05:09:17 UTC 2025

I have some idea here. We probably lose the token (timeout) and get a
non-string. Older PHP was more tolerant in this regard. We are going to
need to fix these one by one as we go along.

Torben Dannhauer <torben at dannhauer.info> schrieb am Fr., 11. Apr. 2025,
23:18:

> Hi Ralph,
>
>
>
> I have the issue as well. I can observer several things and I think they
> are related.
>
> Here my details:
>
>
>
> *a)*
>
> If I leave my Horde on a tab open for long time and then try to use it
> again, it fails with internal error.
>
>
>
> Looking into the logs, I see:
>
>
>
> 2025-04-11T22:39:18+02:00 EMERG: HORDE [horde] TypeError:
> htmlspecialchars(): Argument #1 ($string) must be of type string, array
> given in
> /var/www/torben/web/horde-deployment/vendor/horde/horde/templates/login/login.inc:12
>
> Stack trace:
>
> #0
> /var/www/torben/web/horde-deployment/vendor/horde/horde/templates/login/login.inc(12):
> htmlspecialchars()
>
> #1 /var/www/torben/web/horde-deployment/vendor/horde/horde/login.php(422):
> require('...')
>
> #2 {main} [pid 32788 on line 74 of
> "/var/www/torben/web/horde-deployment/vendor/horde/core/lib/Horde/ErrorHandler.php"]
>
>
>
> *b)*
>
> I played around with gollem and see the strange URL revealing all array
> elements of the horde var:
>
>
>
> https://webmail.dannhauer.de/horde/login.php?*url%5Banchor%5D=&url%5Bparameters%5D%5B_t%5D=1744404421&url%5Bparameters%5D%5B_h%5D=UyLcVK8nxfr8rnGO9E38Nrd6kXk&url%5Braw%5D=1&url%5Burl%5D=https%3A%2F%2Fwebmail.dannhauer.de
> <http://2Fwebmail.dannhauer.de>%2Fgollem%2F&app=gollem*
>
>
>
> using gollem with the (freshly added) mobile view throws as well an error
> with  htmlspecialchars(), therefore I added a debug output to see the
> variable structure:
>
> 2025-04-11T22:59:45+02:00 ERR: HORDE [horde] Vars1: Array
>
> (
>
>     [anchor] =>
>
>     [parameters] => Array
>
>         (
>
>             [_t] => 1744405099
>
>             [_h] => fZpfUwgxGtkGfWkWLJnbTcC2XoE
>
>         )
>
>
>
>     [raw] => 1
>
>     [url] => https://webmail.dannhauer.de/gollem/
>
> )
>
> [pid 50740 on line 51 of
> "/var/www/torben/web/horde-deployment/vendor/horde/view/lib/Horde/View/Helper/Text.php"]
>
> 2025-04-11T22:59:45+02:00 EMERG: HORDE [horde] TypeError:
> htmlspecialchars(): Argument #1 ($string) must be of type string, array
> given in
> /var/www/torben/web/horde-deployment/vendor/horde/view/lib/Horde/View/Helper/Text.php:52
>
> Stack trace:
>
> #0
> /var/www/torben/web/horde-deployment/vendor/horde/view/lib/Horde/View/Helper/Text.php(52):
> htmlspecialchars()
>
> #1
> /var/www/torben/web/horde-deployment/vendor/horde/view/lib/Horde/View/Base.php(427):
> Horde_View_Helper_Text->h()
>
> #2
> /var/www/torben/web/horde-deployment/vendor/horde/horde/templates/login/smartmobile.html.php(6):
> Horde_View_Base->__call()
>
> #3
> /var/www/torben/web/horde-deployment/vendor/horde/view/lib/Horde/View.php(31):
> include('...')
>
> #4
> /var/www/torben/web/horde-deployment/vendor/horde/view/lib/Horde/View/Base.php(567):
> Horde_View->_run()
>
> #5 /var/www/torben/web/horde-deployment/vendor/horde/horde/login.php(408):
> Horde_View_Base->render()
>
> #6 {main} [pid 50740 on line 74 of
> "/var/www/torben/web/horde-deployment/vendor/horde/core/lib/Horde/ErrorHandler.php"]
>
>
>
> *Solution strategy?*
>
> One approach could be to ensure that htmlspecialchars() is always called
> with a string. But this must be done on all calls, and I’m not sure what
> the vasic benefit/idea beyond the horde vars is.
>
> Therefore I think that this approach is not the best one, especially as
> the malformed URL needs to be fixed.
>
> As you mentioned you have an idea, I hope this information helps you to
> spot the bug. Lets phone if we should join forces here. For now I work in
> other corners hoping you’re successful J
>
>
>
> Thanks, Torben
>
>
>
> *Von:* Ralf Lang <ralf.lang at gmail.com>
> *Gesendet:* Freitag, 4. April 2025 21:02
> *An:* Torben Dannhauer <torben at dannhauer.info>
> *Cc:* B Simon <simon.buongiorno at gmail.com>; horde at lists.horde.org
> *Betreff:* Re: [horde] Dev on H6 starts again
>
>
>
> hi simon, can you please provide a snippet from the horde log? I have an
> idea what the issue might be.
>
>
>
> Torben Dannhauer <torben at dannhauer.info> schrieb am Fr., 4. Apr. 2025,
> 20:17:
>
> Hi Simon,
>
> The ugly timeout error I have on my side as well. It’s on the todo list.
>
> As I migrated from H5 to H6, I had not to reset all clients from scratch.
> Me and my bubble uses iPhones, I just deleted all of them in the activesync
> page and they resynced properly.
>
>
>
> Von unterwegs gesendet
> Sent from mobile
>
>
> > Am 04.04.2025 um 18:04 schrieb Simon B <simon.buongiorno at gmail.com>:
> > Hi Torben,
> >
> > This is wonderful news!  But please do no burn yourself out and ask
> > for help when you need it.
> >
> > I have a minor issue...
> >
> > Previously, when I resumed my browser, with my tabs restored, Horde
> > was ready and waiting for me to enter my password and go.
> >
> > Now, I get a rather ugly error .
> >
> > A fatal error has occurred
> >
> > strrpos(): Argument #1 ($haystack) must be of type string, array given
> >
> > Details have been logged for the administrator.
> >
> > And the URL is also weird and not conforming to security best practice.
> >
> >
> https://webmail.mydomain.net/horde/login.php?url%5Banchor%5D=&url%5Bparameters%5D%5Bpage%5D=mailbox&url%5Bparameters%5D%5B_t%5D=1742920995&url%5Bparameters%5D%5B_h%5D=Fs47Rsr4t2ppqThyHZmudm5gNEU&url%5Braw%5D=1&url%5Burl%5D=https%3A%2F%2Fwebmail.mydomain.net%2Fimp%2Fdynamic.php&horde_logout_token=Z5mLOxaXMWsZCT8eaLoU7vz
> >
> > Not super important, but might be an easy fix.
> >
> > Have a nice weekend.
> >
> > Simon B
> >
> >
> > On Sat, 29 Mar 2025 at 18:35, Michael Schlueter <michael at johalla.de>
> wrote:
> >>
> >> Hi Torben,
> >>
> >> Have you had a look at the known issue list in the wiki:
> >> https://wiki.horde.org/Doc/Dev/H6/Developer/KnownIssues
> >>
> >> Thanks
> >> Michael
> >>
> >> Am 29.03.25 um 14:16 schrieb Torben Dannhauer:
> >>> Hi all,
> >>> Just a short update: I got/am in contact with Jan and Ralf. I am now
> added to the maintainer permission level and start slowly the H6
> development.
> >>> I added  already some fixes for wicked, activesync and horde base.
> >>> I work on getting deeper oriented in the code base. And for now fix
> the problems I do observe.
> >>> If you having fixes to get reviews, please
> >>> Inform me on the list, as I’m not yet working with the horde
> bugtracker.
> >>> Let’s work together to geht H6 into stable state!
> >>> Greetings, Torben
> >>> Von unterwegs gesendet
> >>> Sent from mobile
> >>
> >> --
> >> Horde mailing list
> >> Frequently Asked Questions: http://horde.org/faq/
> >> To unsubscribe, mail: horde-unsubscribe at lists.horde.org
> > --
> > Horde mailing list
> > Frequently Asked Questions: http://horde.org/faq/
> > To unsubscribe, mail: horde-unsubscribe at lists.horde.org
> --
> Horde mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: horde-unsubscribe at lists.horde.org
>
>