[horde] New Horde Setup Tool in horde/base v6.0.0alpha15

[Brent]

  Quoting Brent <impuser at bitrealm.com>:

> Quoting Ralf Lang <ralf.lang at gmail.com>:
>
>>>> Two issues (have been this way for a while)
>>>>
>>>> 1)  I still don't know where "start_year" gets assigned? For my  
>>>> Contacts, it only shows from current year to 10 years out (2025  
>>>> to 2035). I can't set anything earlier as it isn't in the  
>>>> dropdown. My "fix" is to hack  
>>>> <install-dir>/vendor/horde/core/lib/Horde/Core/Ui/VarRenderer/Html.php  
>>>> and change line 579.
>>>>
>>>> Orig 579:
>>>> for ($i = $var->type->getProperty('start_year'); $i <=  
>>>> $var->type->getProperty('end_year'); $i++) { */
>>>>
>>>> Changed to:
>>>> for ($i = 1900; $i <= $var->type->getProperty('end_year'); $i++) {
>>>>  
>>>
>>> Please follow/subscribe https://github.com/horde/Core/issues/26
>>>  
>>
>> Solved by horde/form  [1]
>>     Release 3.0.0-beta2 (API Version: 3.0.0-alpha1)[1]
>
>
>
> Date and pictures appear to be working without any  
> modification...that's GREAT! Thanks.
>
> I ran into another issue going from imp-7.0.0alpha16 to  
> imp-7.0.0alpha17: links in emails do not open. You MUST do a  
> right-click "open in new window/tab". Is there a new/different  
> security mechanism in place?
>
> If I revert imp to alpha16, then I can click on links in emails.  
> Updating imp to alpha17 breaks that feature. I'm looking at the  
> diffs in alpha17, but not sure where to start to find that.
>
> Thanks again...working better all the ttime!
>
> brent
>  

Ok, I found the line in imp release alpha 17 that seems to stop links  
from opening in a web browser.

Changing the following line back in Html.php allows links to open:

Alpha17 line 82: (doesn't work)

$data['data'] = '<div>' . _("Loading...") . '</div><iframe  
sandbox="allow-same-origin" class="htmlMsgData" id="' . $uid . '"  
src="javascript:false" frameborder="0"  
style="display:none;height:auto;"></iframe>';

Changing this line back to the code in Alpha16 fixes this problem line  
82: (works)

$data['data'] = '<div>' . _('Loading...') . '</div><iframe  
class="htmlMsgData" id="' . $uid . '" src="javascript:false"  
frameborder="0" style="display:none;height:auto;"></iframe>';

I've no idea what is the correct change or what is up with the "iframe  
sandbox" nomenclature.

brent



Links:
------
[1]  
https://github.com/horde/Form/commit/14bc2bf3b89c29951f3146873fc26a419ac1e0a0