[imp] Little bug in imp 2.3.7

[Jon Parise]

On Fri, Mar 16, 2001 at 03:14:46PM +0100, Jan Schneider wrote:

> > > I found a little bug in lib/base.php of the latest cvs sources:
> > > setlocale takes a string as the first argument, so line 46 should be:
> > > @setlocale('LC_ALL', $language);
> >  
> > setlocale() now takes a constant as the first parameter.  This
> > behavior changed between PHP 4.0.4 and PHP 4.0.5.
> 
> So wouldn't it be nice to check for the PHP version or the existence of a so 
> named constant and definde this constant in IMP if not so?
> Just an idea.
 
Yeah, we talked about that.  We ended up decided that, being we
already require the newest PHP 4 code for other things, we might as
well write the code specifically for PHP 4.0.5 (at the moment,
anyway).

-- 
Jon Parise (jon@csh.rit.edu)  .  Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/  :  Computer Science House Member