[imp] expanding names doesn't work for me....

Jan Schneider jan@horde.org
Wed, 31 Oct 2001 19:33:23 +0100


Nice catch! Commited to cvs, thanks.

Jan.

Zitat von nlin@newton.berkeley.edu:

> 
> Okay, I just dug through the code and I think I've figured out why the 
> "Search fields" panel in Options->Addressbook was confusing me.
> 
> In my turba/config/sources.php file, I have:
> 
>     'search' => array(
>         'name',
>         'email',
>         'workPhone', 
>     ),
> 
> where workPhone is something I added to turba/config/attributes.php.
> But in Options->Addressbook, it was only displaying "Name" & "Email".  It 
> never displayed "workPhone" so I didn't know where things were coming from.
> 
> Anyways, I think this is a bug in the code, and here's the diff.  It's just
> 
> moving the $field_count++ into the if statement.  Sorry if my diff is in the
> 
> wrong format.
> 
> 
> nancy
> 
> -------------
> *** sourceselect.inc    Wed Oct 31 10:11:36 2001
> --- sourceselect.inc.orig       Wed Oct 31 10:04:40 2001
> ***************
> *** 59,66 ****
>               if ($field['search']) {
>                   $marked = isset($selected_fields[$source]) && 
> in_array($field['name'], $selected_fields[$source]) ? 'true' : 'false';
>                   $js .= "searchFields[$source_count][$field_count] = new 
> Array('" . $field['name'] . "', '" . $field['desc'] . "', $marked);\n";
> -                 $field_count++;
>               }
>           }
>           
>           $source_count++;
> --- 59,66 ----
>               if ($field['search']) {
>                   $marked = isset($selected_fields[$source]) && 
> in_array($field['name'], $selected_fields[$source]) ? 'true' : 'false';
>                   $js .= "searchFields[$source_count][$field_count] = new 
> Array('" . $field['name'] . "', '" . $field['desc'] . "', $marked);\n";
>               }
> +             $field_count++;
>           }
>           
>           $source_count++;
> 
> 
> -- 
> IMP mailing list: http://horde.org/imp/
> Archive: http://marc.theaimsgroup.com/?l=imp&r=1&w=2
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe@lists.horde.org
> 
> 


:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::