[imp] General: trashy style

Jan Schneider jan@horde.org
Fri, 18 Jan 2002 13:37:30 +0100


Zitat von Miroslaw Jaworski <mjaw@ipartners.pl>:

> * Jan Schneider (jan@horde.org) [020118 12:30] wrote:
> > Zitat von Miroslaw Jaworski <mjaw@ipartners.pl>:
> > 
> > > Hi 
> > > 
> > > Is it really needed to have 3 concurrent ways of openings tags for 
> > > PHP code? ( <?php <? <?= ) ( Horde2/IMP3 )
> > > 
> > > Many my collegues consider such "style" annoying. 
> > > Someone else thinks the same ?
> > 
> > <? shouldn't be there. See docs/CODING_STANDARDS for details.
> 
> # find horde-2.0 -type f -exec fgrep "<? " {} \;
> <? 
> <? if (isset($style)) { ?>
> <? } ?>
> Always use <?php ?> to delimit PHP code, not the <? ?> shorthand.
> <form name="horde_login" method="post" action="<? Horde::pselfURL() ?>">
> 
> # find horde-2.0 -type f -exec fgrep -l "<? " {} \;
> horde-2.0/admin/css/index.php
> horde-2.0/docs/CODING_STANDARDS
> horde-2.0/templates/login/login.inc
> 
> Ok, i can presume its mistake and will be fixed.
> ( noone noticed because everyone was forced to switch to php short tags,
> when it's working ).

Fixed in cvs.

Jan.

--
::::::::::::::::::::::::::::::::::::::::
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::