[imp] Suggestion for replies.

Ramon Kagan rkagan@yorku.ca
Wed, 6 Feb 2002 10:12:29 -0500 (EST)
Previous message: [imp] Suggestion for replies.
Next message: OT: mimp
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
---------------------- multipart/mixed attachment
This works, I hope my coding is okay.

I've attached the patch for /horde/imp/config/prefs.php
and /horde/imp/compose.php.


Ramon Kagan
York University, Computing and Network Services
Unix Team -  Intermediate System Administrator
(416)736-2100 #20263
rkagan@yorku.ca

On Wed, 6 Feb 2002, Ramon Kagan wrote:

> I'll try, I'm not a proficient coder.
>
> Ramon Kagan
> York University, Computing and Network Services
> Unix Team -  Intermediate System Administrator
> (416)736-2100 #20263
> rkagan@yorku.ca
>
> On Wed, 6 Feb 2002, Jan Schneider wrote:
>
> > Zitat von Ramon Kagan <rkagan@yorku.ca>:
> >
> > > Two options.
> > >
> > > The easiest is to add it to the Options section under Message
> > > Composition,
> > > in essence making it the user's choice in an all or none type idea.  I
> > > think this would suffice.
> >
> > The makes the most sense to me too. Patch?
> >
> > > The other (less attractive) option is where you currently have 'Reply'
> > > and
> > > 'Reply to All' include a checkbox widget between them that says 'with
> > > original' maybe with arrows pointing to either side.  Again this is less
> > > attractive.
> >
> > No, this would clutter the interface too much.
> >
> > > On Wed, 6 Feb 2002, Jan Schneider wrote:
> > >
> > > > Zitat von Ramon Kagan <rkagan@yorku.ca>:
> > > >
> > > > > Hi,
> > > > >
> > > > > It might be a nice option to allow users to decide whether they want
> > > > > to have the original message in a reply.
> > > > >
> > > > > What do you think?
> > > >
> > > > Any ideas how to solve this on the ui side?
> > > >
> > > > Jan.
> >
> > Jan.
> >
> > --
> > http://www.horde.org - The Horde Project
> > http://www.ammma.de - discover your knowledge
> > http://www.tip4all.de - Deine private Tippgemeinschaft
> >
> > --
> > IMP mailing list: http://horde.org/imp/
> > Archive: http://marc.theaimsgroup.com/?l=imp&r=1&w=2
> > Frequently Asked Questions: http://horde.org/faq/
> > To unsubscribe, mail: imp-unsubscribe@lists.horde.org
> >
>
>
> --
> IMP mailing list: http://horde.org/imp/
> Archive: http://marc.theaimsgroup.com/?l=imp&r=1&w=2
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe@lists.horde.org
>


---------------------- multipart/mixed attachment
LS0tIGNvbXBvc2UucGhwCVdlZCBGZWIgIDYgMTA6MDA6NTMgMjAwMg0KKysr
IGNvbXBvc2UucGhwLm5ldwlXZWQgRmViICA2IDA5OjQzOjAyIDIwMDINCkBA
IC01MDksMTggKzUwOSwyMCBAQA0KICAgICAgICAgIGluY2x1ZGVfb25jZSBI
T1JERV9CQVNFIC4gJy9saWIvTUlNRS9TdHJ1Y3R1cmUucGhwJzsNCiAgICAg
ICAgICAkc3RydWN0dXJlID0gaW1hcF9mZXRjaHN0cnVjdHVyZSgkaW1wWydz
dHJlYW0nXSwgJEhUVFBfR0VUX1ZBUlNbJ2luZGV4J10sIEZUX1VJRCk7DQog
ICAgICAgICAgJGF0dGFjaG1lbnRzID0gTUlNRV9TdHJ1Y3R1cmU6OnBhcnNl
KCRzdHJ1Y3R1cmUsICRIVFRQX0dFVF9WQVJTWydpbmRleCddLCAkTWltZUlE
KTsNCi0gICAgICAgICANCi0gICAgICAgICAkcXVvdGVfc3RyID0gIlxuIiAu
IHJ0cmltKCRwcmVmcy0+Z2V0VmFsdWUoJ3F1b3RlX3ByZWZpeCcpKSAuICcg
JzsNCi0gICAgICAgICAkbXNnID0gZmluZEJvZHkoJGF0dGFjaG1lbnRzKTsN
Ci0gICAgICAgICAkd3JhcF93aWR0aCA9ICRwcmVmcy0+Z2V0VmFsdWUoJ3dy
YXBfd2lkdGgnKSAtIHN0cmxlbigkcXVvdGVfc3RyKTsNCi0gICAgICAgICBp
ZiAoJHdyYXBfd2lkdGggPCAyMCkgew0KLSAgICAgICAgICAgICAkd3JhcF93
aWR0aCA9IDIwOw0KKw0KKwkgaWYgKCRwcmVmcy0+Z2V0VmFsdWUoJ3JlcGx5
X3F1b3RlJykpIHsgICAgICAgICANCisgICAgICAgICAgICAkcXVvdGVfc3Ry
ID0gIlxuIiAuIHJ0cmltKCRwcmVmcy0+Z2V0VmFsdWUoJ3F1b3RlX3ByZWZp
eCcpKSAuICcgJzsNCisgICAgICAgICAgICAkbXNnID0gZmluZEJvZHkoJGF0
dGFjaG1lbnRzKTsNCisgICAgICAgICAgICAkd3JhcF93aWR0aCA9ICRwcmVm
cy0+Z2V0VmFsdWUoJ3dyYXBfd2lkdGgnKSAtIHN0cmxlbigkcXVvdGVfc3Ry
KTsNCisgICAgICAgICAgICBpZiAoJHdyYXBfd2lkdGggPCAyMCkgew0KKyAg
ICAgICAgICAgICAgICAkd3JhcF93aWR0aCA9IDIwOw0KKyAgICAgICAgICAg
IH0NCisgICAgICAgICAgICAkbXNnID0gVGV4dDo6d3JhcCgkbXNnLCAkd3Jh
cF93aWR0aCwgJHF1b3RlX3N0cik7DQorICAgICAgICAgICAgJG1zZyAgPSBf
KCJRdW90aW5nIikgLiAnICcgLiAkcWZyb20gLiAiOlxuJHF1b3RlX3N0ciRt
c2ciOw0KKyAgICAgICAgICAgICRtc2cgLj0gIlxuIjsNCiAgICAgICAgICB9
DQotICAgICAgICAgJG1zZyA9IFRleHQ6OndyYXAoJG1zZywgJHdyYXBfd2lk
dGgsICRxdW90ZV9zdHIpOw0KLSAgICAgICAgICRtc2cgID0gXygiUXVvdGlu
ZyIpIC4gJyAnIC4gJHFmcm9tIC4gIjpcbiRxdW90ZV9zdHIkbXNnIjsNCi0g
ICAgICAgICAkbXNnIC49ICJcbiI7DQotICAgICAgICANCi0gICAgICAgICBp
ZiAoaXNzZXQoJGgtPnN1YmplY3QpICYmIChzdHJ0b2xvd2VyKHN1YnN0cihN
SU1FOjpkZWNvZGUoJGgtPnN1YmplY3QpLCAwLCAzKSkgIT0gJ3JlOicpKSB7
DQorICAgICAgICAgDQorCSBpZiAoaXNzZXQoJGgtPnN1YmplY3QpICYmIChz
dHJ0b2xvd2VyKHN1YnN0cihNSU1FOjpkZWNvZGUoJGgtPnN1YmplY3QpLCAw
LCAzKSkgIT0gJ3JlOicpKSB7DQogICAgICAgICAgICAgICRzdWJqZWN0ID0g
J1JlOiAnIC4gTUlNRTo6ZGVjb2RlKCRoLT5zdWJqZWN0KTsNCiAgICAgICAg
ICB9IGVsc2UgaWYgKGlzc2V0KCRoLT5zdWJqZWN0KSkgew0KICAgICAgICAg
ICAgICAkc3ViamVjdCA9IE1JTUU6OmRlY29kZSgkaC0+c3ViamVjdCk7DQo=
---------------------- multipart/mixed attachment
LS0tIHByZWZzLnBocC5kaXN0CVN1biBEZWMgMjMgMTI6MjQ6MzkgMjAwMQ0K
KysrIHByZWZzLnBocC5uZXcJV2VkIEZlYiAgNiAwOTo1ODo1MCAyMDAyDQpA
QCAtNzEsNyArNzEsNyBAQA0KICAgICAnY29sdW1uJyA9PiBfKCJPdGhlciBP
cHRpb25zIiksDQogICAgICdsYWJlbCcgPT4gXygiTWVzc2FnZSBDb21wb3Np
dGlvbiIpLA0KICAgICAnZGVzYycgPT4gXygiQ3VzdG9taXplIGhvdyB5b3Ug
c2VuZCBtYWlsIGFuZCB3aGVyZSBkcmFmdHMgYXJlIHNhdmVkLiIpLA0KLSAg
ICAnbWVtYmVycycgPT4gYXJyYXkoJ3dyYXBfd2lkdGgnLCAncXVvdGVfcHJl
Zml4JywgJ2NvbXBvc2VfcG9wdXAnLA0KKyAgICAnbWVtYmVycycgPT4gYXJy
YXkoJ3dyYXBfd2lkdGgnLCAncmVwbHlfcXVvdGUnLCAncXVvdGVfcHJlZml4
JywgJ2NvbXBvc2VfcG9wdXAnLA0KICAgICAgICAgICAgICAgICAgICAgICAg
J2ZvbGRlcnNlbGVjdCcsICdkcmFmdHNfZm9sZGVyJywgJ2Nsb3NlX2RyYWZ0
JykNCiApOw0KIA0KQEAgLTQxOSw2ICs0MTksMTUgQEANCiAgICAgJ3NoYXJl
ZCcgPT4gZmFsc2UsDQogICAgICd0eXBlJyA9PiAnbnVtYmVyJywNCiAgICAg
J2Rlc2MnID0+IF8oIldyYXAgdGV4dCBhdCB0aGlzIG1hbnkgY2hhcmFjdGVy
cy4iKQ0KKyk7DQorDQorLy8gU2hvdWxkIHRoZSBvcmlnaW5hbCBtZXNzYWdl
IGJlIGluY2x1ZGVkPw0KKyRfcHJlZnNbJ3JlcGx5X3F1b3RlJ10gPSBhcnJh
eSgNCisgICAgJ3ZhbHVlJyA9PiAxLA0KKyAgICAnbG9ja2VkJyA9PiBmYWxz
ZSwNCisgICAgJ3NoYXJlZCcgPT4gZmFsc2UsDQorICAgICd0eXBlJyA9PiAn
Y2hlY2tib3gnLA0KKyAgICAnZGVzYycgPT4gXygiSW5jbHVkZSBvcmlnaW5h
bCBtZXNzYWdlIGluIGEgcmVwbHkuIikNCiApOw0KIA0KIC8vIEhvdyBzaG91
bGQgd2UgcHJlZml4IHF1b3RlZCBsaW5lcyBpbiBhIHJlcGx5Pw0K
---------------------- multipart/mixed attachment--


>From jan@horde.org Date: Wed,  6 Feb 2002 16:12:51 +0100
Return-Path: <jan@horde.org>
Mailing-List: contact imp-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list imp@lists.horde.org
Received: (qmail 21597 invoked from network); 6 Feb 2002 15:14:06 -0000
Received: from mailout07.sul.t-online.com (194.25.134.83)
  by clark.horde.org with SMTP; 6 Feb 2002 15:14:06 -0000
Received: from fwd05.sul.t-online.de 
	by mailout07.sul.t-online.com with smtp 
	id 16YTls-0002Wq-05; Wed, 06 Feb 2002 16:14:04 +0100
Received: from linux.wg.de (320034214675-0001@[80.130.214.39]) by fmrl05.sul.t-online.com
	with esmtp id 16YTlZ-1avTsWC; Wed, 6 Feb 2002 16:13:45 +0100
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g16FCr931194
	for <imp@lists.horde.org>; Wed, 6 Feb 2002 16:12:53 +0100
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@linux by linux.wg.de with HTTP;
	Wed,  6 Feb 2002 16:12:51 +0100
Message-ID: <1013008371.3c6147f3b9a7d@linux.wg.de>
Date: Wed,  6 Feb 2002 16:12:51 +0100
From: Jan Schneider <jan@horde.org>
To: imp@lists.horde.org
References: <1013007564.3c6144cc51df4@horde.riboflavin.net>
In-Reply-To: <1013007564.3c6144cc51df4@horde.riboflavin.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [imp] Fix: Empty Trash Folder

Zitat von "Marcus I. Ryan" <marcus@riboflavin.net>:

> I admit my CVS is a few days out of date, but just in case no one else
> has caught this:
> 
> horde/imp/template/mailbox/actions.inc line 28 checks to see if we're in
> the trash folder by comparing $imp['mailbox'] to IMP::preambleString() .
> $prefs->getValue('trash_folder').  In more recent versions it appears
> that $imp['mailbox'] already includes the preamble (IIRC so that shared
> folders can be used for Drafts, etc.).  I have changed my line 28 to
> read:
>     <?php if ($prefs->getValue('use_trash') && $imp['mailbox'] ==
> $prefs->getValue('trash_folder')): ?> |

You were absolutely right. Commited, thanks.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft
Previous message: [imp] Suggestion for replies.
Next message: OT: mimp
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]