[imp] [Fwd: Problem deleting messages via POP with IMP 3.1]

[Ken Murchison]

Chuck Hagenbuch wrote:
> 
> Quoting Ken Murchison <ken@oceana.com>:
> 
> > I am resending this to the list because I haven't received any responses
> > and I think this is kind of a showstopper if it truely is a problem
> > with the code (and not just a config error).  If it is a config error, I
> > would appreciate any help in tracking it down.
> 
> Well, things work here. It's possible that you have c-client problems; a
> lot of things are possible, but aside from the DELE not being sent (that's
> good to know), you haven't given us a lot to work on. Can you put some
> debugging echos or Horde::logMessage calls into mailbox.php, in the
> DELETE_MESSAGE case, and see where it's getting?

Chuck, thanks for the response.  I did a little digging and found the
problem, which is the fact that the IMP_Message::delete() does an exact
string match on the protocol (== 'pop3'), and I have 'pop3/notls' as my
protocol.  Here is a patch against 3.1 RC2 which does a substring match.

Thanks for all of the good work.

Ken



--- Message.php.orig    Wed Apr 17 12:53:59 2002
+++ Message.php Wed Apr 17 13:10:55 2002
@@ -258,7 +258,7 @@
                         ': <i>' . imap_last_error() . '</i>',
HORDE_ERROR);
                     $return_value = false;
                 }
-                if ($imp['protocol'] == 'pop3') {
+                if (!strncmp($imp['protocol'], 'pop3', 4)) {
                     imap_expunge($imp['stream']);
                     imap_close($imp['stream']);
                     IMP::authenticate();


-- 
Kenneth Murchison     Oceana Matrix Ltd.
Software Engineer     21 Princeton Place
716-662-8973 x26      Orchard Park, NY 14127
--PGP Public Key--    http://www.oceana.com/~ken/ksm.pgp