[imp] PATCH: compose.php delocalization

Steve Stavropoulos steve@math.upatras.gr
Sat Nov 9 22:19:01 2002


 This is a small patch that removes some localization from
imp/compose.php in the sake of better communication between people with
different languages. For more, please see the patch, I think it is
selfexplanatory.

 Email is about communication between people. People from every corner
of the world, people with different languages. The one language that is
chosen to be the one language that everyone should speak is english, so
when an imp user wants to sent an email we _shouldn't_ assume that he
wants to sent it in the language that he has chosen for the imp
interface. For example Jan Schneider's replies start with a line like
this:

Zitat von Chuck Hagenbuch <chuck@horde.org>:

How many people in here know what "Zitat von" means? I don't. In general
I think that ALL the lines that get put in an email by imp when a user
chooses to compose a mail should be in english, so they can be
understood by all.
 Localization is a very good thing, but there are limits!

 And this is the patch:

--- /home/adm/steve/.//webmail/horde/imp/compose.php    Thu Jun  6 01:49:02 2002
+++ imp/compose.php     Sat Nov  9 23:12:02 2002
@@ -612,27 +627,27 @@

          $msg  = "\n\n";
          $msg .= "\n----- ";
-         $msg .= sprintf(_("Forwarded message from %s"), $message_source);
+         $msg .= sprintf("Forwarded message from %s", $message_source);
          $msg .= " -----\n";

          if (isset($h->date) && $h->date) {
-             $msg .= _("    Date: ") . MIME::decode($h->date);
+             $msg .= "Date: " . MIME::decode($h->date);
              $msg .= "\n";
          }
          if (isset($h->from) && is_array($h->from)) {
-             $msg .= _("    From: ") . IMP::addrArray2String($h->from);
+             $msg .= "From: " . IMP::addrArray2String($h->from);
              $msg .= "\n";
          }
          if (isset($h->reply_to) && is_array($h->reply_to)) {
-             $msg .= _("Reply-To: ") . IMP::addrArray2String($h->reply_to);
+             $msg .= "Reply-To: " . IMP::addrArray2String($h->reply_to);
              $msg .= "\n";
          }
          if (isset($h->subject) && $h->subject) {
-             $msg .= _(" Subject: ") . MIME::decode($h->subject);
+             $msg .= "Subject: " . MIME::decode($h->subject);
              $msg .= "\n";
          }
          if (isset($h->to) && is_array($h->to)) {
-             $msg .= _("      To: ") . IMP::addrArray2String($h->to);
+             $msg .= "To: " . IMP::addrArray2String($h->to);
              $msg .= "\n";
          }

@@ -641,13 +656,13 @@
          $attachments = MIME_Structure::parse($structure, $index, $MimeID);
          $msg .= "\n";
          $msg .= findBody($attachments);
-         $msg .= "\n----- " . _("End forwarded message") . " -----\n";
+         $msg .= "\n----- " . "End forwarded message" . " -----\n";

          if (isset($h->subject)) {
-             $subject = _("Fwd:") . ' ' . MIME::decode($h->subject);
+             $subject = "Fwd:" . ' ' . MIME::decode($h->subject);
              $ACTION_TEXT = _("Forward:") . ' ' . MIME::decode($h->subject);
          } else {
-             $subject = _("Fwd:");
+             $subject = "Fwd:";
              $ACTION_TEXT = _("Forward");
          }



More information about the imp mailing list