[imp] whitelist patch...

[Amith Varghese]

> > Quoting Amith Varghese <amith at xalan.com>:
> >
> > | Here is a patch against CVS HEAD that integrates whitelist
> > functionality
> > | within
> > | IMP using Sam (SpamAssassin Module).  The patch uses the
> > | registry->hasMethod
> > | calls to determine whether or not to show the link within IMP.  Please
> > | let me
> > | know if there are any questions.
> >
> > This is probably better accomplished by creating a 'sam' module for the
> > IMP_Filter:: library.
> 
> I see no need for creating a sam module if the necessary modules are already
> available through the registry. Creating a 'registry' or 'application'
> module for the Filter backend makes more sense to me.
> 
> OTOH this patch mostly adds the UI for having whitelist capabilities at all
> and using it through registry methods like we already do with blacklists
> sound much cleaner and less overhead than implementing a while Filter driver.

I implemented this the exact same way as "Blacklist" is done.  The only thing I
did different was change navbar.inc so that it showed "Whitelist" when the
registry had mail/whitelistFrom and mail/showWhitelist functions.  

And as Jan said, all of the code was pretty much there in the sam.  I did add
some api functions to sam so that it could handle whitelisting - which should
have been there in the first place (but all the code was there to support
viewing and modifiying the whitelist)

I don't see this really as filtering, I'm not deleting messages.  Right now I
have SpamAssassin configured to put SPAM: in the subject line but still deliver
the message. If SpamAssassin marks a particular e-mail as SPAM I want to have
the ability to store in MySQL the fact that i want SpamAssassin to ignore e-mail
from that sender and not mark it as SPAM.  The next time SpamAssassin sees an
e-mail from that Sender it won't put SPAM: in the subject line.

If I were to implement this using IMP_Filter, it would seem to me that there wou
ld be some redundant code that is already in Sam.  And it would probably also
mean that Blacklist should be changed as well.  Also how would you configure
this IMP_Filter:: backend for Sam (like what table, DB, username, and password
to use).

If the patch isn't acceptable I can look into using IMP_Filter:: but I'm not
sure where to begin.

Thanks
Amith