Fwd: Re: [imp] New Mail Popups in IMP 3.2.2-RC1

[Jochen Roderburg]

Seems this didn't make it to the list ;-)

----- Weitergeleitete Nachricht von Jochen Roderburg <Roderburg at Uni-Koeln.DE>
-----
    Datum: Wed,  6 Aug 2003 16:33:15 +0200
    Von: Jochen Roderburg <Roderburg at Uni-Koeln.DE>
Antwort an: Jochen Roderburg <Roderburg at Uni-Koeln.DE>
 Betreff: Re: [imp] New Mail Popups in IMP 3.2.2-RC1
      An: Jochen Roderburg <Roderburg at Uni-Koeln.DE>

Zitat von Jochen Roderburg <Roderburg at uni-koeln.de>:
 
> I have just made a test installation of the new Horde/Imp Release
> Candidates
> and
> found a little bug:
> I get these New Mail Popup windows when new Mail arrives although the
> respective
> option is not set.

Hmm, poked a little around in the code and saw the following differences
between
IMP 3.2.1 and 3.2.2:
In mailbox.php there is a variable newmail_popup

old:

$newmail_popup = (Horde::getFormData('newmail_popup') == 'no') ? false : true;
.....
if ($newmail_popup && $prefs->getValue('nav_popup') && ($newmsgs > 0)) {
    include IMP_TEMPLATES . '/mailbox/alert.inc';
}

new:

$newmail_popup = ((Horde::getFormData('newmail_popup') == 'no') &&
                  $prefs->getValue('nav_popup')) ? false : true;
......
if ($newmail_popup && ($newmsgs > 0)) {
    include IMP_TEMPLATES . '/mailbox/alert.inc';
}

Seems the test of the preference value has wandered from the usage into the
initialization, but is the result really the same ???


Jochen Roderburg
ZAIK/RRZK
University of Cologne
Robert-Koch-Str. 10                 Tel.:   +49-221/478-7024
D-50931 Koeln                       E-Mail: Roderburg at rrz.Uni-Koeln.DE
Germany


----- Ende der weitergeleiteten Nachricht -----