[imp] [PATCH] confirm spam report

Jan Schneider jan at horde.org
Fri Aug 29 09:46:47 PDT 2003


Zitat von Rob Lineweaver <rlineweaver at harrisonburg.k12.va.us>:

> Quoting Rob Lineweaver <rlineweaver at harrisonburg.k12.va.us>:
> >
> > But if there are no objections... I can resubmit a (simpler) always-on
> > confirmation patch.
> >
>
> here it is...

Looks good, but I'm a nitpicker. ;-)
I'd like to see the link in the message view still working without
javascript. Instead of submitting by javascript, you could add an onclick
event to that link that triggers the user prompt and returns false if he
denies.

But I commited that patch for the mailbox view already.

> Also, in imp/message.php, the patch changes the notice "This message has
> been
> reported as spam." to "The message...", because when you see that notice,
> you
> are already looking at the next message in your mailbox (or your mailbox
> view,
> depending on your prefs), and either way it is a bit confusing which
> message is
> "this" message.

Makes sense.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft


More information about the imp mailing list