[imp] imp-3.2.2 messes up from addresses

[Tim Winders]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thanks, Peter.  I just applied this patch and it didn't make a difference.

I think the problem is IMP trying to read the user/passwd file.  I think,
with 3.1, it inserted the username from the passwd file.  Now, with 3.2.2,
that's not happening.

Again, I am referring to the FROM: address, not the TO: address.

The FROM address displays in IMP as:

	FROM: twinders at southplainscollege.edu (Default Identity)

But, when the recipient gets the email, it is actually delivered as:

	FROM: "\"twinders"\"@southplainscollege.edu

and I'm not sure why.  Is anyone else having this problem?

=== Tim

     **********************************************
        Tim Winders, MCSE, CNE, CCNA
        Associate Dean of Information Technology
        South Plains College
        Levelland, TX  79336

        Phone:	806-894-9611 x 2369
        FAX:	806-894-1549
        Email:	TWinders at SouthPlainsCollege.edu
     **********************************************


On Tue, 16 Sep 2003, Peter Solodov wrote:

> On 16 Sep 2003, Tim Winders wrote:
> > I have upgraded from imp-3.1 to imp-3.2.2 and now, when sending
> > email from IMP, the From addresses are not getting sent correctly.
> >
> > The end user cannot change the from address.
> >
> > Now, when sending email, it gets delivered to the recipient as
> > \"twinders\"@southplainscollege.edu
> >
> > There is something with the quotes / quoting going on that I can't
> > figure out.
> >
> > Any clues on this one?
>
> Yep, just finished fixing it (only in one place though).  It still
> happens when addresses are inserted from address book, didn't find
> where that happens yet.  The diff is after the signature.  I was going
> to send that same question to the list but then found where to fix it
> and decided to do that first.
>
>         - Peter
>
> --
> Peter Solodov                    | Concordia University
> http://alcor.concordia.ca/~peter | Montreal, QC, Canada
>
> --- imp-3.2.2/lib/IMP.php.20030916      2003-09-16 21:15:50.000000000
> -0400
> +++ imp-3.2.2/lib/IMP.php       2003-09-16 21:10:54.000000000 -0400
> @@ -1381,7 +1381,23 @@
>          $filter .= "()<>@,;:\\\"[]\1\2\3\4\5\6\7\10\11\12\13\14\15\16\17\20\21\22\23\24\25\26\27\30\31\32\33\34\35\36\37\177";
>
>          if (strcspn($str, $filter) != strlen($str)) {
> -            return '"' . str_replace('"', '\\"', str_replace('\\', '\\\\', $str)) . '"';
> +            // 2003/09/16 Peter Solodov: take surrounding quotes into account
> +
> +            $start = 0;
> +            $end = strlen($str);
> +
> +            if ($str[0] == '"')
> +            {
> +                $start = 1;
> +            }
> +            if ($str[strlen($str) - 1] == '"')
> +            {
> +                $end = strlen($str) - 2;
> +            }
> +
> +            $sub_str = substr($str, $start, $end);
> +
> +            return '"' . str_replace('"', '\\"', str_replace('\\',
> +            '\\\\', $sub_str)) . '"';
>          } else {
>              return $str;
>          }
>
> --
> IMP mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe at lists.horde.org
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (OSF1)
Comment: Made with pgp4pine 1.76

iD8DBQE/aGdvTPuHnIooYbwRAlWxAJ9sg2S0lnkUV5OAg/hO3H0oiy8+0ACfWEz6
DGhI5nuuvhoWdG7HJa+uOyA=
=KQ4T
-----END PGP SIGNATURE-----