[imp] Re: [turba] Imp/Turba integration problems?

[Daniel Eckl]

Well, that would be a Mozilla problem. Because when using the "onclick"
eventhandler and the called javascript function returns "false", the link
destination should not be called.

I don't know if the horde developers will commit a patch that only works around
a bug in one browser. But if the other browsers don't activate the link
destination correctly, then it should be no problem, no matter what the link
destination is...

Greets,
Daniel

Zitat von CJ Kucera <horde at apocalyptech.com>:

> On Tue, Dec 30, 2003 at 03:34:46PM +0100, Daniel Eckl wrote:
> > Hmmm, strange....
> >
> > Cannot reproduce. CVS checkout today at 10:00
>
> Still has the problem for me...  It tracked it down, and on Mozilla
> at least, the problem appears to be the HREF="" which gets sent in
> the link.  When that's changed to a "#" it's much happier for me:
>
> diff -u -3 -p -r2.260 compose.inc
> --- templates/compose/compose.inc       30 Dec 2003 01:07:59 -0000      2.260
> +++ templates/compose/compose.inc       30 Dec 2003 15:36:12 -0000
> @@ -333,7 +333,7 @@ $locked_charset = $prefs->isLocked('send
>                <tr valign="middle">
>  <?php if ($registry->hasMethod('contacts/search')): ?>
>  <?php $contacts_url = Horde::applicationUrl('contacts.php'); ?>
> -                <?php echo Menu::createItem('', _("Address Book"),
> 'addressbook-red.gif', NULL, 'contacts', 'window.open(\'' . $contacts_url .
> '\', \'contacts\',
>
\'toolbar=no,location=no,status=yes,scrollbars=yes,resizable=yes,width=650,height=350,left=100,top=100\');
> return false;', 'item', 'widget'); ?>
> +                <?php echo Menu::createItem('#', _("Address Book"),
> 'addressbook-red.gif', NULL, 'contacts', 'window.open(\'' . $contacts_url .
> '\', \'contacts\',
>
\'toolbar=no,location=no,status=yes,scrollbars=yes,resizable=yes,width=650,height=350,left=100,top=100\');
> return false;', 'item', 'widget'); ?>
>                  <?php echo Menu::createItem('', _("Expand Names"),
> 'expand.gif', NULL, NULL,
> "document.compose.actionID.value='compose_expand_addr'; uniqSubmit(); return
> false;", 'item', 'widget'); ?>
>  <?php endif; ?>
>  <?php if (!empty($conf['utils']['spellchecker'])): ?>
>
> -CJ
>
> > Zitat von CJ Kucera <horde at apocalyptech.com>:
> > > Thanks...  However, the fix seems to introduce a page refresh on the
> > > composition screen.  This is all right if you address the message
> > > before writing a subject or message body, but if you're written anything
> > > before hitting the Address Book link, now it'll refresh the composition
> > > window and you'll lose what you typed.  I'm guessing that's not ideal
> > > behavior.
>
> --
> WOW: Kakistocracy        |  "The ships hung in the sky in much the same
> apocalyptech.com/wow     |    way that bricks don't." - Douglas Adams,
> horde at apocalyptech.com   |     _The Hitchhiker's Guide To The Galaxy_
>
>
>