[imp] Compose Window -> Address Book

[Mike Bydalek]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Mike Bydalek <mbydalek at zivix.com>:
>
>> The problem is, when clicking "Address Book" I get the following from the
>> Javascript console:
>>
>> Error: uncaught exception: [Exception... "Component returned failure code:
>> 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"
>> nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
>> chrome://browser/content/browser.js :: Shutdown :: line 445"  data: no]
>>
>> Works fine in IE, so not sure what the problem is.
>
> Browser bug.

Yeah, but I wonder what changed in the past week or so.  I have a "stable"
install that I mainly use and a pure-CVS one, and the stable one works in
Mozilla, while the CVS is broken.   Interesting tho...

>
>> I search for doesn't have an e-mail address.  Something could be 
>> done here in
>> terms of not displaying entries that don't have an e-mail address 
>> (what's the
>> point?) or displaying an error?  I'd do it, but I figure Chuck will have a
>> better idea & way to do it.
>
> Perhaps, and perhaps not, but I also have a heck of a lot else to do. So why
> don't you come up with a patch? :)
Ask and ye shall receive!

Of course there's a billion ways to do this, so I just did it the "easiest" I
guess...

-Mike

*** contacts.inc.orig   Fri Feb  6 20:36:39 2004
--- contacts.inc        Fri Feb  6 20:40:34 2004
***************
*** 39,49 ****
--- 39,51 ----
      <td width="45%"><select name="search_results" multiple="multiple"
size="10" width="200"
onchange="document.contacts.search_results[0].selected=false"<?php echo
$select_event ?>>
        <option value=""><?php echo _("* Please select address(es) *")
?></option>
          <?php foreach ($addresses as $addr): ?>
+                 <?php if (strlen($addr['email']) > 0) :?>
              <?php if ($display == 'email'): ?>
                  <option value="<?php echo rawurlencode($addr['name']) ?>"<?php
echo $option_event ?>><?php echo $addr['email'] ?></option>
              <?php else: ?>
                  <option value="<?php echo rawurlencode($addr['email'])
?>"<?php echo $option_event ?>><?php echo $addr['name'] ?></option>
              <?php endif; ?>
+             <?php endif; ?>
          <?php endforeach; ?>
          </select>
      </td>