[imp] imp cvs head viewing messages with html error

Vijay Mahrra vijay.mahrra at es.easynet.net
Fri Jul 30 09:09:31 PDT 2004


I had a bug in IMP-CVS HEAD

Warning: Invalid argument supplied for foreach() in
/data/apache/vhosts/www.mahrra.com/htdocs/horde/imp/lib/Identity/imp.php
on line 311

when viewing messages which had a HTML attachment, not sure why exactly
but changing the offending line seemed to work:

Index: imp.php
===================================================================
RCS file: /repository/imp/lib/Identity/imp.php,v
retrieving revision 1.37
diff -u -r1.37 imp.php
--- imp.php     17 May 2004 19:05:43 -0000      1.37
+++ imp.php     30 Jul 2004 12:01:38 -0000
@@ -307,7 +307,7 @@

          foreach ($this->_identities as $key => $identity) {
              $tieaddr = $this->getValue('tieto_addr', $key);
-            if (!empty($tieaddr)) {
+            if (!empty($tieaddr) && is_array($tieaddr)) {
                  foreach ($tieaddr as $val) {
                      if (!isset($list[$val])) {
                          $list[$val] = $key;


More information about the imp mailing list