[imp] Re: Patch for mbox downloads in IMP 3.2.5
ross at rbecker.org
Sun Sep 12 10:59:48 PDT 2004
I took a look at CVS HEAD code, and I downloaded both imp and horde
modules tagged head, and I am unable to locate a file "Compress.php",
which is referenced in imp/folders.php. Can you tell me which module
this file is located in? It looked like it would have been part of
horde, but "cvs co -r HEAD horde", a find command doesn't locate
anything named Compress.php. I'll finish this for IMP 4.x assuming I
can locate the compression module.
Chuck Hagenbuch wrote:
> Quoting Ross Becker <ross at rbecker.org>:
>> I've patched IMP 3.2.5 to use a tmpfile() stream for generating mboxes
>> for download- this way they're automatically removed if the PHP process
>> goes away for an unexpected reason. It gets a tmpfile, generates the
>> mbox from the folder into that, returns the file handle, then seeks to
>> the end and uses ftell() to find the size of the stream, and then does
>> 8k blocks to deliver this to the user. This prevents large mail folders
>> from blowing up PHP's memory size. I've generated a unified diff of my
>> changes- is there any interest in this patch for going into CVS?
> It'd be best if it was against CVS HEAD, but it's an interesting idea.
> I've been
> looking at Zend Download Server as well; I may write a class for
> wrapping either
> this behavior or ZDS.
> Btw, any reason you didn't use fpassthru()?
> "Regard my poor demoralized mule!" - Juan Valdez
More information about the imp