[imp] Custom folder icons not shown in sidebar

[Oliver Kuhl]

Hi,

Jan Schneider wrote:
> Zitat von Oliver Kuhl <okuhl at netcologne.de>:
> 
>>So what is your opinion about this issue? Should the hook always return
>>the filename only and the <img> will be generated in folders.php, or
>>should the hook maybe return an array with every information needed,
>>just like this?
>>
>>         $newmailboxes['INBOX.Spam'] = array(
>>             'spam.png',
>>             _("Spam"),
>>             'width="16" height="16" style="vertical-align:middle"',
>>             $GLOBALS['registry']->getImageDir('imp').'/folders'
>>         );
>>
>>         return $newmailboxes;
>>
>>Whatever, the change must be made somewhere. Just to make sure, my patch
>>will fit you developer's ideas, please tell me how you think about it.
> 
> 
> I would say that the hook should return the full image path, i.e.  
> $GLOBALS['registry']->getImageDir('imp') . '/folders/spam.png'.
> 
> But this will break bc, which is fine in hooks, as long as it is well  
> documented. That means that you need both versions in hooks.php.dist,  
> and a note in doc/UPGRADING.

I tried to implement something like you proposed, but it did not fit and
there would have been really huge changes in the tree-logic. So I
decided to return an array of the needed values in the hook.

Patches are here:
http://bugs.horde.org/ticket/?id=3132

Regards,
   Ollie.