[imp] link to show/hide deleted messages (patch)

[Jan Kuipers]

Quoting Graeme Wood <Graeme.Wood at ed.ac.uk>:

> On Tue, 14 Mar 2006, Michael M Slusarz wrote:
>
>> Quoting Graeme Wood <Graeme.Wood at ed.ac.uk>:
>>
>> > On Tue, 14 Mar 2006, Michael M Slusarz wrote:
>> >
>> >> Quoting Graeme Wood <Graeme.Wood at ed.ac.uk>:
>> >>
>> >> > I'm trying out IMP 4.1 and I noticed this happening. I am   
>> pretty sure that
>> >> > there is an error in lib/Mailbox.php on line 447 and that:
>> >> >
>> >> > $ret_array = array('hide' => false, 'purge' => true);
>> >> >
>> >> > show be:
>> >> >
>> >> > $ret_array = array('hide' => true, 'purge' => true);
>> >> >
>> >> > But I am not absolutely certain yet. Certainly that fixes the   
>> problem for
>> >> > me and I can't see any reason why the hide button should be   
>> hidden in that
>> >> > bit of logic.
>> >>
>> >> You are using Thread Sorting.  We can't hide deleted messages using
>> >> thread sorting because there is no way with PHP's imap library we can
>> >> sort by thread on anything less than the full mailbox.
>> >
>> > How do you know that? I am sorry but you are wrong. I am not using Thread
>> > Sorting. I checked that and I also checked all the preference settings
>> > that might influence it.
>>
>> But do you have any deleted messages in the current mailbox?  Because
>> that's all the piece of code listed above does - it hides the
>> Show/Hide link if there are no deleted messages in the mailbox.
>
> In my case I do. If I delete a message then the purge button appears and
> the hide delete button does not. Only by patching that bit of code do I
> get the hide delete button to appear. It seems quite illogical to me that
> the code should read:
>
> if I have a setting to show the delete button then don't show the delete
> button
>
> --
> =============================================================================
> Graeme Wood                                 Email: Graeme.Wood at ed.ac.uk
> Unix Systems Support                        Phone: +44 131 650 5003
> The University of Edinburgh                 Fax:   +44 131 650 6552
> =============================================================================
> --
> IMP mailing list - Join the hunt: http://horde.org/bounties/#imp
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: imp-unsubscribe at lists.horde.org
>

The attached patch for imp/lib/Mailbox.php solves this problem. I'm  
not sure it is the right solution, but it works for me.

-- 
Jan Kuipers,
Systeembeheer Lauwers College
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Mailbox.php.diff
Type: text/x-patch
Size: 1060 bytes
Desc: not available
Url : http://lists.horde.org/archives/imp/attachments/20060320/c8910dee/Mailbox.php.bin