[imp] compose window resets with large attachments

[Michael M Slusarz]

Quoting Andrew Morgan <morgan at orst.edu>:

> On Tue, 8 May 2007, Jan Schneider wrote:
>
>> Zitat von Andrew Morgan <morgan at orst.edu>:
>>
>>> On Tue, 8 May 2007, Chuck Hagenbuch wrote:
>>>
>>>> Quoting Andrew Morgan <morgan at orst.edu>:
>>>>
>>>>> So...  Back to my original question.  Is there a way to prevent the
>>>>> compose form from being "reset" when a too-large attachment is uploaded?
>>>>> Can anyone else reproduce this behavior or is it just me?
>>>>
>>>> It's not just you. If a file exceeds max_post_size, we get _no_ POST
>>>> data at all. So in those cases this is not much we can do unfortunately.
>>>
>>> That's what I figured.  :(
>>>
>>> So...  what about my suggestion to have a size limit in IMP itself?  Then
>>> the POST would still work but IMP could discard the attachment after it
>>> checks the size.  I might be able to come up with a patch for this.
>>
>> That's what the upload_max_filesize setting is for. This one can be
>> catched, and actually is catched from the attachment code. Just set
>> the max_post_size high enough to not get hit before the
>> upload_max_filesize limit gets hit.
>
> Aha!  I didn't understand this distinction.
>
> Now, when I attempt to upload a file too large, the form does not reset
> and I get a notification at the top which says 'Did not attach
> "mylargefile" as the file was empty.'.  I'd prefer something which tells
> the user that the file may have been too large, but this is much better
> than resetting the form.

If I remember correctly, we can't distinguish on the server side  
between an empty file and a max_post_size violation.  That's why it is  
necessary to set your parameters the way Jan mentions above.

michael