[imp] email page with 'loading' for ever on Horde webmail 5.0.2

[Michael M Slusarz]

Quoting Eric Van Bocxlaer <evb at ping.be>:

> Michael M Slusarz <slusarz <at> horde.org> writes:
>
>>
>> Quoting Eric Van Bocxlaer <evb <at> ping.be>:
>>
>> > Ralf Lang <lang <at> b1-systems.de> writes:
>> >
>> >>
>> >> > Found something in the php log file:
>> >> > [14-Dec-2012 22:25:32 UTC] PHP Fatal error:  Call to a member function
>> > rewind
>> >> > () on a non-object in C:\php\pear\Horde\Imap\Client\Socket.php on
>> >> line 2878
>> >> >
>> >> > Is a non-object in php the same as a null?
>> >> > It seems not, because just before line 2878 there is following test:
>> >> >         if (is_null($data)) {
>> >> >             return $params;
>> >> >         }
>> >> >
>> >>
>> >> A non-object is anything but an object, including null, integer,
>> >> strings, resources and arrays.
>>
>> [snip]
>>
>> > $tmp->next() is not protected by a 'is_ojbect'
>> > Correct?
>>
>> All of this is irrelevant, since none of this code exists in the most
>> recent version of the Horde_Imap_Client package.  You need to upgrade
>> that package.
>>
>> michael
>>
>> ___________________________________
>> Michael Slusarz [slusarz <at> horde.org]
>>
> Ok, downloaded via pear
> PEAR.HORDE.ORG AVAILABLE UPGRADES (STABLE):
> ===========================================
> CHANNEL        PACKAGE           LOCAL          REMOTE          SIZE
> pear.horde.org Horde_ActiveSync  2.0.7 (stable) 2.0.11 (stable) 154kB
> pear.horde.org Horde_Core        2.0.4 (stable) 2.1.1 (stable)  1339kB
> pear.horde.org Horde_Imap_Client 2.2.3 (stable) 2.3.2 (stable)  153kB
> pear.horde.org Horde_Mail        2.0.1 (stable) 2.0.2 (stable)  28kB
>
> After installation, same behaviour, imp loads for ever.
> But for the moment no php fatal error in the logs.
>
> You said "since none of this code exists in the most recent version of the
> Horde_Imap_Client package".
> But the same code exists as before:
>
>         // This is disposition information
>         if (is_object($tmp = $data->next())) {
>             $ob->setDisposition($tmp->rewind());
>
>             foreach ($this->_parseStructureParams($tmp->next(), 'content-
> disposition') as $key => $val) {
>                 $ob->setDispositionParameter($key, $val);
>             }
>         }

My mistake.  This code was changed in 2.3.1, but because people are  
using ancient unsupported versions of PHP we needed to revert for  
2.3.2.  It has been changed back in 2.4.0 (which I also thought had  
been released but has apparently not).

2.4.0 should be good to go so I will release that version now.

michael

___________________________________
Michael Slusarz [slusarz at horde.org]