[imp] Imp - No "Empty Spam"

[Simon Wilson]

----- Message from Simon Wilson <simon at simonandkate.net> ---------
    Date: Wed, 13 Feb 2013 20:22:19 +1000
    From: Simon Wilson <simon at simonandkate.net>
Subject: Re: [imp] Imp - No "Empty Spam"
      To: Michael M Slusarz <slusarz at horde.org>
      Cc: "imp at lists.horde.org" <imp at lists.horde.org>


> On 13/02/2013, at 4:48 PM, Michael M Slusarz <slusarz at horde.org> wrote:
>
>> Quoting Simon Wilson <simon at simonandkate.net>:
>>
>>> On 13/02/2013, at 3:16 AM, Jan Schneider <jan at horde.org> wrote:
>>>
>>>>
>>>> Zitat von Simon Wilson <simon at simonandkate.net>:
>>>>
>>>>> "Display the "Empty Spam" link in the menubar?" preference in  
>>>>> Imp 6.0.3 doesn't appear to actually do anything. Is that by  
>>>>> design or a bug? Or is it hidden somewhere? Right click the  
>>>>> folder there is an "empty" option, but that's not what the  
>>>>> preference is stating...
>>>>>
>>>>> Nor does trash appear to have an Empty Trash item in the menu bar.
>>>>>
>>>>> Are these "design choices" making us do two clicks where one  
>>>>> would suffice, or just not yet implemented?
>>>>>
>>>>> Simon
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Simon Wilson
>>>>> M: 0400 12 11 16
>>>>
>>>> It's only displayed in the basic view.
>>>> --
>>>> Jan Schneider
>>>
>>> Which response just leads me to repeat:
>>>
>>>> Are these "design choices" making us do two clicks where one  
>>>> would suffice, or just not yet implemented?
>>
>> And I'm not sure the relevance of this statement(?)
>>
>> Obviously the "Empty Trash" and "Empty Spam" menu options make no  
>> sense in the dynamic view since they are already implemented (for  
>> all mailboxes, for that matter).
>>
>> michael
>
> Not trying to be cantankerous, forgive me if it came over that way...
>
> It was a genuine question based on my previous use of H4 basic. My  
> question was whether it was a design choice or not yet done. You  
> have now answered I believe that it is a design choice.
> Thank you. I will write a wording patch for the prefs file so that  
> the pref help text makes a little more sense...
>
> Simon.
> --

/imp/config/prefs.php

--- prefs.php   2013-01-29 16:57:18.363609228 +1000
+++ prefs.php.diff      2013-02-13 21:38:44.248380989 +1000
@@ -1403,7 +1403,7 @@
  $_prefs['empty_spam_menu'] = array(
      'value' => 0,
      'type' => 'checkbox',
-    'desc' => _("Display the \"Empty Spam\" link in the menubar?"),
+    'desc' => _("Display the \"Empty Spam\" link in the menubar?  
(Only applies in Basic view)"),
      'suppress' => function() {
          return  
!$GLOBALS['injector']->getInstance('IMP_Factory_Imap')->create()->access(IMP_Imap::ACCESS_FOLDERS);
      }








--
Simon Wilson
M: 0400 12 11 16
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: PGP Digital Signature
URL: <http://lists.horde.org/archives/imp/attachments/20130213/8b4206b6/attachment.bin>