[imp] preview of attached files in imp

[francis picabia]

On Fri, Sep 12, 2014 at 3:31 PM, Michael M Slusarz <slusarz at horde.org> wrote:
> Quoting francis picabia <fpicabia at gmail.com>:
>
>> On Sun, Mar 3, 2013 at 9:10 PM, Michael M Slusarz <slusarz at horde.org>
>> wrote:
>>>
>>>
>>> Quoting Petr Černík <cernik at fel.cvut.cz>:
>>>
>>>>> On my ubuntu system the magic file is /usr/share/file/magic.mgc, this
>>>>> is a compiled binary magic file. There is a link pointing to it at
>>>>> /usr/share/misc/magic.mgc
>>>>>
>>>>> I'm using the latest imp and, although my attachment requirements are
>>>>> limited to image files, I haven't had any issues. Are you sure you have all
>>>>> the required php modules installed? Just a thought.
>>>>
>>>>
>>>>
>>>> Doh ... shame.  U are rights. I mistyped character in name of magic.mgc.
>>>> Thank you.
>>>
>>>
>>>
>>> I've made clearer in the configuration file that you *really* shouldn't
>>> need to set this configuration value.
>>>
>>
>> I'm not clear what is supposed to happen with default
>> settings and use of attachment link in Compose window.
>>
>> My users have begun to report this error happens with word
>> docs. Images or a txt attachment are fine and view inline
>> in a new window.
>>
>> I'm running horde 5.1.5 and imp 6.1.5
>>
>> I'm OK with any behavior other than an error.  If it did a download
>> like the Drafts folder view, that works too.  The error is specific
>> to using the link in the Compose.
>>
>> I've tried including or not including the magic.mgc configuration,
>> with web server
>> restart.  No difference.  The test script earlier in this thread
>> does work for a .doc file when run from php on Linux shell.
>>
>> $ php /tmp/test.php
>>
>> application/msword
>>
>> Clicking on the word doc link in a compose window, for Windows client,
>> Linux client, IE or Chrome,
>>
>> I get this error:
>>
>> A fatal error has occurred
>>
>> Could not display attachment data.
>>
>> 1. IMP_Compose_View->composeAttachPreview()
>> /usr/local/www/horde/imp/view.php:44
>>
>> Details
>>
>> The full error message is logged in Horde's log file, and is shown
>> below only to administrators. Non-administrative users will not see
>> error details.
>>
>> IMP_Exception Object
>> (
>>     [details] =>
>>     [logged] => 1
>>     [_logLevel:protected] => 0
>>     [message:protected] => Could not display attachment data.
>>     [string:Exception:private] =>
>>     [code:protected] => 0
>>     [file:protected] => /usr/local/www/horde/imp/lib/Compose/View.php
>>     [line:protected] => 54
>>     [trace:Exception:private] => Array
>>         (
>>             [0] => Array
>>                 (
>>                     [file] => /usr/local/www/horde/imp/view.php
>>                     [line] => 44
>>                     [function] => composeAttachPreview
>>                     [class] => IMP_Compose_View
>>                     [type] => ->
>>                     [args] => Array
>>                         (
>>                             [0] => 1
>>                             [1] => 1
>>                             [2] =>
>>                         )
>>
>>                 )
>>
>>         )
>>
>>     [previous:Exception:private] =>
>> )
>>
>> I'm using mime_drivers.php as shipped, no mime_drivers.local.php
>> nor mime_drivers.d/
>>
>> I don't intend to set up abiword or whatever in mime drivers.
>>
>> I'd think if the user has an application, it should launch the helper app
>> as it does on any regular web site.
>
>
> That's not the way it works.  Compose previews are only available for data
> that can be rendered on the server side.

Is there a way we can disable this for document types where there is
no server side renderer?  Either make it a non-link, or produce
another type of error?

It really confuses people to see errors like this.  Once something
like this happens during the session, everything is distrusted and
they question whether the message was delivered, etc.