[ingo] Problem with blacklist move-to-folder action

Ahmed ashihab at alcahest.com
Wed Apr 2 10:45:06 PST 2003


Hi,

I've noticed a couple of problems with Ingo CVS (2.4.2003 9GMT):

1. The blacklist display for the folder list was placing the list outside
   the selection box (see simple patch to fix this)

2. The option to move the message to a folder is not honoured in 2 ways
     a. The script simply has discard as an action which is not correct
        it should have "fileinto <folder>"

     b. the subsequent displays of the blacklist page reverts back to
        "delete messages completely" which ties up with the script action
        but is wrong.

Unfortunately my PHP abilities are exhausted by the type of patch I've
included fixing the second problem is beyond me.

Ahmed...



-------------- next part --------------
--- blacklist.inc	Wed Apr  2 10:41:07 2003
+++ blacklist.inc.new	Wed Apr  2 10:43:42 2003
@@ -18,7 +18,5 @@
                         <input type="radio" name="action" value="mark" <?php if ($blacklist_folder == INGO_BLACKLIST_MARKER) echo 'checked="checked" ' ?>/> <?php echo _("Mark message as deleted") ?><br />
                         <input type="radio" name="action" value="folder" <?php if (!empty($blacklist_folder) && $blacklist_folder != INGO_BLACKLIST_MARKER) echo 'checked="checked" ' ?>/> <?php echo _("Move message to folder:") ?>
-                        <select name="folder">
-                            <?php echo $folder_list ?>
-                        </select>
+			<?php echo $folder_list ?>
                         <br/><br/>
                         <textarea name="blacklist" rows="15" cols="80"><?php echo implode("\n", $blacklist_addresses) ?></textarea>


More information about the ingo mailing list