[ingo] Bug: incorrect action definitions

Leena Heino Leena.Heino at uta.fi
Wed May 7 18:12:19 PDT 2003


It would seem that in cvs releng and head there is multiple different
definitions to INGO_STORAGE_ACTION_WHITELIST and
INGO_STORAGE_ACTION_VACATION.

In lib/Storage.php it is defined as:
INGO_STORAGE_ACTION_WHITELIST is 9
INGO_STORAGE_ACTION_VACATION is 8

In config/prefs.php.dist it is assumed that:
INGO_STORAGE_ACTION_WHITELIST is 8
INGO_STORAGE_ACTION_VACATION is 9

These different definitions results strange filters page where eg.
vacation rule has a correct link to vacation.php and picture
vacation.gif but incorrect alt text "Edit Whitelist".

Here's the patch to cvs releng (and head):
--- ingo/lib/Storage.php.orig	Mon Apr 28 00:14:26 2003
+++ ingo/lib/Storage.php	Wed May  7 16:54:30 2003
@@ -29,11 +29,11 @@
 /** @const INGO_STORAGE_ACTION_BLACKLIST */
 define('INGO_STORAGE_ACTION_BLACKLIST', 7);

-/** @const INGO_STORAGE_ACTION_WHITELIST */
-define('INGO_STORAGE_ACTION_WHITELIST', 8);
-
 /** @const INGO_STORAGE_ACTION_VACATION */
-define('INGO_STORAGE_ACTION_VACATION', 9);
+define('INGO_STORAGE_ACTION_VACATION', 8);
+
+/** @const INGO_STORAGE_ACTION_WHITELIST */
+define('INGO_STORAGE_ACTION_WHITELIST', 9);

 /**
  * Ingo_Storage:: defines an API to store the various filter rules.

-- 
  -- Leena Heino (liinu at uta.fi)


More information about the ingo mailing list