[ingo] Buggy Rule Edit - Looses rules & one off problems

[Michael J Rubinsky]

Quoting Lukas Weiss <lukas.weiss at raiffeisen.it>:

> Am 27.07.2015 um 19:33 schrieb Michael J Rubinsky:
>>
>> Quoting Michael J Rubinsky
>> <mrubinsk at horde.org>:
>>
>>> Quoting Adam Tauno Williams
>>> <awilliam at whitemice.org>:
>>>
>>>> On Fri, 2015-07-24 at 10:23 -0400, Adam Tauno Williams wrote:
>>>>> I am using the latest Ingo - hoping it had resolved some of these
>>>>> issues.
>>>>> Ingo 3.2.5 Horde 5.2.6
>>>>> But I am still consistently getting buggy rule creation and list edit
>>>>> behavior.  Reordering rules may not result in the expected order and
>>>>> some rules just disappear.  Editing a rule, by clicking on the name,
>>>>> may result in seeing the next-rule-down on the list.
>>>>> The loosing of rules is really frustrating.
>>>>
>>>> It appears to be fairly reproducible by changing the order of the rules
>>>> using drag-n-drop, it seems to work, it says reordering saved
>>>> successfully.... but if you then hit "Filter rules" causing a list
>>>> reload the reordered rule is now gone.
>>>>
>>>> Can anyone confirm [or not] that they can reproduce this issue?
>>>
>>> Probably:
>>>
>>> http://bugs.horde.org/ticket/14064
>>>
>>> http://bugs.horde.org/ticket/13643
>>
>>
>> ...and these are both now fixed in Git for Framework_5_2 for Ingo 3.2.6
>>
>>
>>
>
> i think this hidden row in filters.html.php should also have the  
> class "filtersRow", since its id also has to be re-labled by  
> filters.js.
> after adding the class, everything seems to work fine.
>
> filters.html.php:
>
> <?php if ($v === false): ?>
>   <div id="filtersrow_<?php echo $k ?>" style="display:none">
> <?php else: ?>
>
> filters.js:
>
> rows = $('filterslist').select('DIV.filtersRow');

This (and another minor issue) have already been fixed in Git and will  
be in the next bug fix release.


-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5751 bytes
Desc: S/MIME Signature
URL: <http://lists.horde.org/archives/ingo/attachments/20150827/9f1b911b/attachment.bin>