Fwd: Re: [jonah] Typo in channels.php

[Chuck Hagenbuch]

1. Please keep threads on the list.

2. This patch just looks like it breaks things to me. If you still think it
should be applied, please justify the changes and explain what they fix/what
was wrong.

----- Forwarded message from Patrick.Brossier at mgm.fr -----
    Date: Fri, 28 Feb 2003 19:41:11 +0100
    From: Patrick Brossier <Patrick.Brossier at mgm.fr>
Reply-To: Patrick Brossier <Patrick.Brossier at mgm.fr>
 Subject: Re: [jonah] Typo in channels.php
      To: Chuck Hagenbuch <chuck at horde.org>


Le vendredi, 28 fév 2003, à 19:11 Europe/Paris, Chuck Hagenbuch a écrit 
:
>
> This line number doesn't seem to make sense, and I can *barely* follow 
> what
> you're trying to say here (try using a diff next time?), but I *think* 
> I've
> fixed what you're talking about in CVS.

channels.php
* $Horde: jonah/channels.php,v 1.22 2003/02/24 17:09:33 chuck Exp $
23c23
< $channelView = Horde::getFormData('channelview', 'standard');
---
 > $channelView = Horde::getFormData('channelView', 'standard');
41c41
<     if (@is_readable($conf['paths']['data'] . '/html/' . $key . 
'.html')) {
---
 >     if (@is_readable($conf['paths']['data'] . '/html/' . $key . 
'-standard.html')) {
46c46
<             $modified = filemtime($conf['paths']['data'] . '/html/' . 
$key . '.html');
---
 >             $modified = filemtime($conf['paths']['data'] . '/html/' . 
$key . '-standard.html');
158c158
<             echo Jonah::buildViewWidget('channelview', $channelView, 
'view.submit()');
---
 >             echo Jonah::buildViewWidget('channelView', $channelView, 
'view.submit()');
161c161
<             readfile($conf['paths']['data'] . '/html/' . $channelName 
. '-' . $channelView . '.html');
---
 >             echo 
String::convertCharset(Jonah::buildChannelDisplay($channelName, 
$channelView), 'UTF-8');
173c173
<                 echo '<input type="hidden" name="channelview" 
value="' . $channelView . '" />';
---
 >                 echo '<input type="hidden" name="channelView" 
value="' . $channelView . '" />';


templates/channels/edit.inc
11c11
<     <?php echo Jonah::buildViewWidget('channelview', $channelView) ?>
---
 >     <?php echo Jonah::buildViewWidget('channelView', $channelView) ?>



----- End forwarded message -----


-chuck

--
Charles Hagenbuch, <chuck at horde.org>
must ... find ... acorns ... *thud*