[jonah] Typo in channels.php

Chuck Hagenbuch chuck at horde.org
Fri Feb 28 15:37:40 PST 2003


Quoting Patrick Brossier <Patrick.Brossier at mgm.fr>:

> In channels.php 1.23
> 
> 41c41
> if (@is_readable($conf['paths']['data'] . '/html/' . $key . '.html')) {
> 
> Files $key . '.html' don't exist.
> You have $key . '-detailed.html'
>                 '-standard.html'
>                 '-compact.html'
>                 '-ultracompact.html'

Ah, okay. But none of those are guaranteed, so this wasn't quite right.
Fixed in CVS.

> 161c161
>            readfile($conf['paths']['data'] . '/html/' . $channelName
>  . '-' . $channelView . '.html');
> You write file in UTF-8 in a page who has its own charset.

Okay. So looking at the original patch:

<             readfile($conf['paths']['data'] . '/html/' . $channelName 
. '-' . $channelView . '.html');
---
 >             echo 
String::convertCharset(Jonah::buildChannelDisplay($channelName, 
$channelView), 'UTF-8');


... but I'm not sure how we assume that the file is in UTF-8? Jan? Seems
like a few other steps would be needed here.

-chuck

--
Charles Hagenbuch, <chuck at horde.org>
must ... find ... acorns ... *thud*


More information about the jonah mailing list