[jonah] Typo in channels.php

Jan Schneider jan at horde.org
Sat Mar 1 00:44:17 PST 2003


Quoting Chuck Hagenbuch <chuck at horde.org>:

> > 161c161
> >            readfile($conf['paths']['data'] . '/html/' . $channelName
> >  . '-' . $channelView . '.html');
> > You write file in UTF-8 in a page who has its own charset.
> 
> Okay. So looking at the original patch:
> 
> <             readfile($conf['paths']['data'] . '/html/' . $channelName
> . '-' . $channelView . '.html');
> ---
>  >             echo
> String::convertCharset(Jonah::buildChannelDisplay($channelName,
> $channelView), 'UTF-8');
> 
> 
> ... but I'm not sure how we assume that the file is in UTF-8? Jan? Seems
> like a few other steps would be needed here.

We should save all generated html pages in utf-8 and convert them to the
user's charset when we display them.

If we didn't touch anything yet, the pages probably get stored in the xml
parser's default output charset.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft


More information about the jonah mailing list