[kronolith] CVS editeventaction.php

[Chuck Hagenbuch]

Quoting mays@optonline.net:

> The recent CVS change to addeventaction.php removing the duplicate
> Horde::applicationUrl also needs to be applied to editeventaction.php.

Done, thanks.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
Some fallen angels have their good reasons.


>From chuck@horde.org Date: Wed,  8 Aug 2001 15:31:16 -0400
Return-Path: <chuck@horde.org>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 14071 invoked from network); 8 Aug 2001 19:33:11 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.198.7)
  by horde.org with SMTP; 8 Aug 2001 19:33:11 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 7F03439F6; Wed,  8 Aug 2001 15:31:16 -0400 (EDT)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@localhost by marina.horde.org with HTTP;
	Wed,  8 Aug 2001 15:31:16 -0400
Message-ID: <997299076.3b71938434f81@marina.horde.org>
Date: Wed,  8 Aug 2001 15:31:16 -0400
From: Chuck Hagenbuch <chuck@horde.org>
To: kronolith@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Explain change?

Jan, I don't understand this commit:

http://cvsweb.horde.org/diff.php/kronolith/lib/WeekView.php?r1=1.14&r2=1.15&f=h

I tested events before 8am before this, and they worked fine. This change 
causes some bad breakage in certain cases (events show up multiple times, html 
is _all_ out of whack), and it doesn't seem necessary. Can you explain what it 
fixes?

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
Some fallen angels have their good reasons.


>From janmailing@gmx.de Date: Thu,  9 Aug 2001 10:17:34 +0000
Return-Path: <janmailing@gmx.de>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 39755 invoked from network); 9 Aug 2001 10:25:10 -0000
Received: from mailout05.sul.t-online.com (HELO mailout05.sul.t-online.de) (194.25.134.82)
  by horde.org with SMTP; 9 Aug 2001 10:25:10 -0000
Received: from fwd00.sul.t-online.de 
	by mailout05.sul.t-online.de with smtp 
	id 15Umzz-0007V8-00; Thu, 09 Aug 2001 12:25:07 +0200
Received: from linux.wg.de (320034214675-0001@[217.0.157.39]) by fmrl00.sul.t-online.com
	with esmtp id 15Umzw-1PTkeGC; Thu, 9 Aug 2001 12:25:04 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f79AHYV32580
	for <kronolith@lists.horde.org>; Thu, 9 Aug 2001 12:17:34 +0200
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@mail.wg.de by linux.wg.de with HTTP;
	Thu,  9 Aug 2001 10:17:34 +0000
Message-ID: <997352254.3b72633e5f492@linux.wg.de>
Date: Thu,  9 Aug 2001 10:17:34 +0000
From: Jan Schneider <janmailing@gmx.de>
To: kronolith@lists.horde.org
References: <997299076.3b71938434f81@marina.horde.org>
In-Reply-To: <997299076.3b71938434f81@marina.horde.org>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [kronolith] Explain change?

Zitat von Chuck Hagenbuch <chuck@horde.org>:

> Jan, I don't understand this commit:
> 
> http://cvsweb.horde.org/diff.php/kronolith/lib/WeekView.php?
r1=1.14&r2=1.15&f=h

If you have an event that starts before 8am it is shown in the 8am time slot in 
the week view.
 
> I tested events before 8am before this, and they worked fine. This change 
> causes some bad breakage in certain cases (events show up multiple times,

I didn't see that case. How can I reproduce this?

> html 
> is _all_ out of whack), and it doesn't seem necessary. Can you explain what

I see the html mess up too, but not when I tested the code. This has to be 
fixed of course.

Jan.


>From chuck@horde.org Date: Thu,  9 Aug 2001 10:06:10 -0400
Return-Path: <chuck@horde.org>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 56071 invoked from network); 9 Aug 2001 14:08:05 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.198.7)
  by horde.org with SMTP; 9 Aug 2001 14:08:05 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id CA42039F4; Thu,  9 Aug 2001 10:06:10 -0400 (EDT)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@localhost by marina.horde.org with HTTP;
	Thu,  9 Aug 2001 10:06:10 -0400
Message-ID: <997365970.3b7298d282b06@marina.horde.org>
Date: Thu,  9 Aug 2001 10:06:10 -0400
From: Chuck Hagenbuch <chuck@horde.org>
To: kronolith@lists.horde.org
References: <997299076.3b71938434f81@marina.horde.org> <997352254.3b72633e5f492@linux.wg.de>
In-Reply-To: <997352254.3b72633e5f492@linux.wg.de>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] Explain change?

Quoting Jan Schneider <janmailing@gmx.de>:

> If you have an event that starts before 8am it is shown in the 8am time slot 
> in the week view.

Okay, I see this. I'll take a look at it.

> I didn't see that case. How can I reproduce this?

I wasn't able to narrow it down; it involved a certain number of events. I'll 
try and be more exact if I can't solve the before 8am problem with the rest of 
the code how it is now.

> I see the html mess up too, but not when I tested the code. This has to be 
> fixed of course.

You see it now? With anything besides pre-8am events?

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
Some fallen angels have their good reasons.