[kronolith] Error exporting events

Chuck Hagenbuch chuck@horde.org
Fri, 28 Sep 2001 10:53:45 -0400


Quoting Jan Schneider <jan@horde.org>:

> OK, I added this to kronlith's data.php.

The way this was added won't work... session_start() is already called in 
base.php; doing it again like this won't work. Sorry I wasn't specific; I 
should have said that the problem is IE's issues with SSL downloads, and you 
need to use that quirk somehow.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"What was and what may be lie, like children whose faces we cannot see, in the 
arms of silence. All we ever have is here, now." - Ursula K. Le Guin


>From jrkuipers@lauwerscollege.nl Date: Mon,  1 Oct 2001 09:03:38 +0200
Return-Path: <jrkuipers@lauwerscollege.nl>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 28122 invoked from network); 1 Oct 2001 07:04:11 -0000
Received: from c3207.upc-c.chello.nl (HELO linux.lauwerscollege.nl) (212.187.3.207)
  by clark.horde.org with SMTP; 1 Oct 2001 07:04:11 -0000
Received: (from www@localhost)
	by linux.lauwerscollege.nl (8.11.6/8.8.7) id f9173dX16206
	for kronolith@lists.horde.org; Mon, 1 Oct 2001 09:03:39 +0200
Received: from 212.187.3.207 ( [212.187.3.207])
	as user jrkuipers@localhost by webmail.lauwerscollege.nl with HTTP;
	Mon,  1 Oct 2001 09:03:38 +0200
Message-ID: <1001919818.3bb8154ae64b3@webmail.lauwerscollege.nl>
Date: Mon,  1 Oct 2001 09:03:38 +0200
From: Jan Kuipers <jrkuipers@lauwerscollege.nl>
To: kronolith@lists.horde.org
References: <1001485094.3bb1732673d94@webmail.lauwerscollege.nl> <1001519063.3bb1f7d74e623@linux.wg.de> <1001522446.3bb2050e88f75@webmail.lauwerscollege.nl> <1001530642.3bb22512beb00@linux.wg.de> <1001579392.3bb2e3800f5c0@webmail.lauwerscollege.nl> <1001580346.3bb2e73a448e1@linux.wg.de> <1001589530.3bb30b1aeb80c@webmail.lauwerscollege.nl> <1001590511.3bb30eef70802@linux.wg.de> <1001592777.3bb317c9c9d73@webmail.lauwerscollege.nl> <1001598065.3bb32c7204d4a@webmail.lauwerscollege.nl> <1001603269.3bb340c55a86f@linux.wg.de> <1001659298.3bb41ba25a5a2@webmail.lauwerscollege.nl> <1001662772.3bb42934d7e7e@linux.wg.de> <1001676880.3bb4605073d79@webmail.lauwerscollege.nl> <1001677916.3bb4645cb348e@jan.dip.ammma.net> <1001678736.3bb46790e1580@webmail.lauwerscollege.nl> <1001687171.3bb4888345038@marina.horde.org> <1001687850.3bb48b2a4cbed@jan.dip.ammma.net>
In-Reply-To: <1001687850.3bb48b2a4cbed@jan.dip.ammma.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] Error exporting events

Citeren Jan Schneider <jan@horde.org>:

> OK, I added this to kronlith's data.php.
> 
> Jan, please give it another try.

Still doesn't work :(

-- 
Jan Kuipers,
Systeembeheer Lauwers College


>From wolff@yahoo.com Date: Mon,  1 Oct 2001 02:10:57 -0700
Return-Path: <jesse_wolff@yahoo.com>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 30912 invoked from network); 1 Oct 2001 09:04:57 -0000
Received: from adsl-63-196-6-8.dsl.snfc21.pacbell.net (HELO tiny.crankybear.com) (63.196.6.8)
  by clark.horde.org with SMTP; 1 Oct 2001 09:04:57 -0000
Received: (from nobody@localhost)
	by tiny.crankybear.com (8.11.6/8.11.2) id f919AwW06174
	for kronolith@lists.horde.org; Mon, 1 Oct 2001 02:10:58 -0700
X-Authentication-Warning: tiny.crankybear.com: nobody set sender to jesse_wolff@yahoo.com using -f
Received: from 192.168.10.2 ( [192.168.10.2])
	as user jesse@localhost by www.crankybear.com with HTTP;
	Mon,  1 Oct 2001 02:10:57 -0700
Message-ID: <1001927457.3bb8332142fae@www.crankybear.com>
Date: Mon,  1 Oct 2001 02:10:57 -0700
From: Jesse Wolff <jesse_wolff@yahoo.com>
To: kronolith@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: daily recurrence calculation - sql driver

Hi.

I updated to the latest cvs tonight and noticed that recurrences are almost 
complete for the sql driver!

There are two issues I ran into, one I know how to fix and the other I don't so 
I'll just mention it.

1) An event with a daily recurrence and a recur interval > 1 day doesn't show 
up in the month view. The problem lead me to the daily recurrences calculation -
 nextRecurrence() in sql.php, case KRONOLITH_RECUR_DAILY - and I'm pretty sure 
it's not being done correctly.

To fix it, line 230 of sql.php should use the ceil() function instead of the 
floor() function.

current: 
$recur = (floor($diff->mday / $event->recurInterval)) * $event->recurInterval;

fix:
$recur = (ceil($diff->mday / $event->recurInterval)) * $event->recurInterval;

The calculation with floor() correctly returns the next recurrence date only 
when the passed date ($afterDate) is the next recurrence date which is why it 
shows up correctly in the summary, day, and week views and not in the month 
view unless the recur interval is 1 day. It fails in the month view for the 
following reason:

If the event startdate is 10/2/2001 and the recurInterval is 2 (days), 
month.php first calls nextRecurrence() passing it 10/3/2001. based on the above 
calculation using floor(), $recur equals 0 when it should be 2.

I looked at a lot of examples and I'm pretty sure that the calculation using 
ceil() correctly returns the next recurrence after the passed date ($afterDate).

After changing it, you can test it and it should show up correctly in all 
views. BUT make sure your start time isn't equal to 12:00AM due to the next 
issue.


2) Daily and weekly recurrences display properly (with the above change) except 
when the event start time is 12AM. This is a problem whether you make the above 
change or not.

To see this, create an event with a daily recurrence repeating every 3 or more 
days and a start time of 12AM. You'll see in the summary, daily, and weekly 
views that the event and it's recurrences also show up on the previous days. 
The month view is fine.

So it's some kind of boundary issue with 12AM. I think nextRecurrence() is 
incorrectly being called first with the previous day.

Thanks,
Jesse 


>From wolff@yahoo.com Date: Mon,  1 Oct 2001 16:50:09 -0700
Return-Path: <jesse_wolff@yahoo.com>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 84597 invoked from network); 1 Oct 2001 23:44:08 -0000
Received: from adsl-63-196-6-8.dsl.snfc21.pacbell.net (HELO tiny.crankybear.com) (63.196.6.8)
  by clark.horde.org with SMTP; 1 Oct 2001 23:44:08 -0000
Received: (from nobody@localhost)
	by tiny.crankybear.com (8.11.6/8.11.2) id f91NoB414108
	for kronolith@lists.horde.org; Mon, 1 Oct 2001 16:50:11 -0700
X-Authentication-Warning: tiny.crankybear.com: nobody set sender to jesse_wolff@yahoo.com using -f
Received: from 192.168.10.2 ( [192.168.10.2])
	as user jesse@localhost by www.crankybear.com with HTTP;
	Mon,  1 Oct 2001 16:50:09 -0700
Message-ID: <1001980209.3bb901319fc0d@www.crankybear.com>
Date: Mon,  1 Oct 2001 16:50:09 -0700
From: Jesse Wolff <jesse_wolff@yahoo.com>
To: kronolith@lists.horde.org
References: <1001927457.3bb8332142fae@www.crankybear.com>
In-Reply-To: <1001927457.3bb8332142fae@www.crankybear.com>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] daily recurrence calculation - sql driver

Hi.

Attached is a patch to fix both of the issues I mentioned. They both occur in 
sql.php so they won't adversely affect mcal.

I tested it with a bunch of cases so recurrences should show up correctly now 
in all of the views no matter what the start time, except of course the 
Monthly:Same weekday recurrence which isn't yet implemented for the sql driver.

There's still an issue with the times for recurrences and multi-day events in 
the summary view but I'll send through another patch for that.

Jesse.

Index: lib/Driver/sql.php
===================================================================
RCS file: /repository/kronolith/lib/Driver/sql.php,v
retrieving revision 1.19
diff -r1.19 sql.php
128c128
<                     if ($next && Kronolith::compareDates($next, $endDate) <= 0
) {
---
>                     if ($next && Kronolith::compareDates($next, $endDate) < 0)
 {
230c230
<             $recur = (floor($diff->mday / $event->recurInterval)) * $event->re
curInterval;
---
>             $recur = (ceil($diff->mday / $event->recurInterval)) * $event->rec
urInterval;



Quoting Jesse Wolff <jesse_wolff@yahoo.com>:

> Hi.
> 
> I updated to the latest cvs tonight and noticed that recurrences are almost
> 
> complete for the sql driver!
> 
> There are two issues I ran into, one I know how to fix and the other I don't
> so 
> I'll just mention it.
> 
> 1) An event with a daily recurrence and a recur interval > 1 day doesn't show
> 
> up in the month view. The problem lead me to the daily recurrences
> calculation -
>  nextRecurrence() in sql.php, case KRONOLITH_RECUR_DAILY - and I'm pretty
> sure 
> it's not being done correctly.
> 
> To fix it, line 230 of sql.php should use the ceil() function instead of the
> 
> floor() function.
> 
> current: 
> $recur = (floor($diff->mday / $event->recurInterval)) *
> $event->recurInterval;
> 
> fix:
> $recur = (ceil($diff->mday / $event->recurInterval)) *
> $event->recurInterval;
> 
> The calculation with floor() correctly returns the next recurrence date only
> 
> when the passed date ($afterDate) is the next recurrence date which is why it
> 
> shows up correctly in the summary, day, and week views and not in the month
> 
> view unless the recur interval is 1 day. It fails in the month view for the
> 
> following reason:
> 
> If the event startdate is 10/2/2001 and the recurInterval is 2 (days), 
> month.php first calls nextRecurrence() passing it 10/3/2001. based on the
> above 
> calculation using floor(), $recur equals 0 when it should be 2.
> 
> I looked at a lot of examples and I'm pretty sure that the calculation using
> 
> ceil() correctly returns the next recurrence after the passed date
> ($afterDate).
> 
> After changing it, you can test it and it should show up correctly in all 
> views. BUT make sure your start time isn't equal to 12:00AM due to the next
> 
> issue.
> 
> 
> 2) Daily and weekly recurrences display properly (with the above change)
> except 
> when the event start time is 12AM. This is a problem whether you make the
> above 
> change or not.
> 
> To see this, create an event with a daily recurrence repeating every 3 or
> more 
> days and a start time of 12AM. You'll see in the summary, daily, and weekly
> 
> views that the event and it's recurrences also show up on the previous days.
> 
> The month view is fine.
> 
> So it's some kind of boundary issue with 12AM. I think nextRecurrence() is 
> incorrectly being called first with the previous day.
> 
> Thanks,
> Jesse 
> 
> -- 
> Kronolith mailing list: http://horde.org/kronolith/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> 




>From wolff@yahoo.com Date: Mon,  1 Oct 2001 17:53:43 -0700
Return-Path: <jesse_wolff@yahoo.com>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 85754 invoked from network); 2 Oct 2001 00:47:42 -0000
Received: from adsl-63-196-6-8.dsl.snfc21.pacbell.net (HELO tiny.crankybear.com) (63.196.6.8)
  by clark.horde.org with SMTP; 2 Oct 2001 00:47:42 -0000
Received: (from nobody@localhost)
	by tiny.crankybear.com (8.11.6/8.11.2) id f920rjm14667
	for kronolith@lists.horde.org; Mon, 1 Oct 2001 17:53:45 -0700
X-Authentication-Warning: tiny.crankybear.com: nobody set sender to jesse_wolff@yahoo.com using -f
Received: from 192.168.10.2 ( [192.168.10.2])
	as user jesse@localhost by www.crankybear.com with HTTP;
	Mon,  1 Oct 2001 17:53:43 -0700
Message-ID: <1001984023.3bb9101705f1f@www.crankybear.com>
Date: Mon,  1 Oct 2001 17:53:43 -0700
From: Jesse Wolff <jesse_wolff@yahoo.com>
To: kronolith@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] sql driver patch - multiday events

Thanks Jan for applying the patch to cvs.

I still run into 2 problems with the summary view (lib/api.php). When the fix 
was made in cvs the checks for the driver type where not included and changed 
some of the logic a bit. 

Here are the issues and some proposed fixes. It's all based on the latest cvs. 
I've tested the fixes and with them, recurrences and multi-day events should 
both show up correctly in the summary view. 

1) The times for recurrence events don't show correctly when the recurrence 
start date is greater than the current time.

This problem is due to the second part of the if statement on line 33-34:

if (!$event->hasRecurType(KRONOLITH_RECUR_NONE) &&
                 $event->startTimestamp < $now) {

I can't find a reason why this check is necessary for the sql driver and it 
causes the above problem. If mcal doesn't need it as well we can take it out by 
changing the line to:

if (!$event->hasRecurType(KRONOLITH_RECUR_NONE)) {

If mcal needs it, we can change it to:

$driver = $GLOBALS['conf']['calendar']['driver'];
if (!$event->hasRecurType(KRONOLITH_RECUR_NONE) &&
    ($driver != 'mcal' ||
    ($driver == 'mcal' && $event->startTimestamp < $now))) {


2) The times for multi-day events don't show up correctly.

This is due to line 44:

$event->endTimestamp = $event->startTimestamp + $event->durMin * 60;

For the sql driver it shouldn't be included. If it's not needed by mcal it can 
be deleted. If it's needed by mcal it will need to be wrapped by a check for 
the driver.

if ($driver == 'mcal') {
    $event->endTimestamp = $event->startTimestamp + $event->durMin * 60;
}


Thanks again,
Jesse.

Quoting Jan Schneider <janmailing@gmx.de>

>Many thanks, great work!
>
>Zitat von Jesse Wolff <jesse_wolff@yahoo.com>:
>
>> Hey all,
>> 
>> Attached is a patch based on the latest cvs that allows you to correctly 
>> displays events that span multiple days when using the sql driver. It should
>> display correctly in all views - day, week, month and horde summary. There's
>> no time limit on how long an event can last.


>From jan@horde.org Date: Tue,  2 Oct 2001 11:03:21 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 95059 invoked from network); 2 Oct 2001 09:04:17 -0000
Received: from mailout03.sul.t-online.com (HELO mailout03.sul.t-online.de) (194.25.134.81)
  by clark.horde.org with SMTP; 2 Oct 2001 09:04:17 -0000
Received: from fwd01.sul.t-online.de 
	by mailout03.sul.t-online.de with smtp 
	id 15oLTL-0007ly-07; Tue, 02 Oct 2001 11:04:15 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.86]) by fmrl01.sul.t-online.com
	with esmtp id 15oLTA-1AelCSC; Tue, 2 Oct 2001 11:04:04 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f9293Lc18588
	for <kronolith@lists.horde.org>; Tue, 2 Oct 2001 11:03:21 +0200
Received: from 62.225.101.66 ( [62.225.101.66])
	as user jan@mail.wg.de by jan.dip.ammma.net with HTTP;
	Tue,  2 Oct 2001 11:03:21 +0200
Message-ID: <1002013401.3bb982d94acf8@jan.dip.ammma.net>
Date: Tue,  2 Oct 2001 11:03:21 +0200
From: Jan Schneider <jan@horde.org>
To: kronolith@lists.horde.org
References: <1001927457.3bb8332142fae@www.crankybear.com> <1001980209.3bb901319fc0d@www.crankybear.com>
In-Reply-To: <1001980209.3bb901319fc0d@www.crankybear.com>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [kronolith] daily recurrence calculation - sql driver

Many thanks for this nice catch and patch.

As you probably realized the recurrence calculation can make you some headaches 
and I'm glad that someone dives into the code and tries to fix the issues.

I still want to test your patches (also the multiday) as soon as I have the 
time but I want you to know that I'm very happy about your work.

Jan.

Zitat von Jesse Wolff <jesse_wolff@yahoo.com>:

> Hi.
> 
> Attached is a patch to fix both of the issues I mentioned. They both occur in
> 
> sql.php so they won't adversely affect mcal.
> 
> I tested it with a bunch of cases so recurrences should show up correctly now
> 
> in all of the views no matter what the start time, except of course the 
> Monthly:Same weekday recurrence which isn't yet implemented for the sql
> driver.
> 
> There's still an issue with the times for recurrences and multi-day events in
> 
> the summary view but I'll send through another patch for that.
> 
> Jesse.
> 
> Index: lib/Driver/sql.php
> ===================================================================
> RCS file: /repository/kronolith/lib/Driver/sql.php,v
> retrieving revision 1.19
> diff -r1.19 sql.php
> 128c128
> <                     if ($next && Kronolith::compareDates($next, $endDate)
> <= 0
> ) {
> ---
> >                     if ($next && Kronolith::compareDates($next, $endDate) <
> 0)
>  {
> 230c230
> <             $recur = (floor($diff->mday / $event->recurInterval)) *
> $event->re
> curInterval;
> ---
> >             $recur = (ceil($diff->mday / $event->recurInterval)) *
> $event->rec
> urInterval;
> 
> 
> 
> Quoting Jesse Wolff <jesse_wolff@yahoo.com>:
> 
> > Hi.
> > 
> > I updated to the latest cvs tonight and noticed that recurrences are
> almost
> > 
> > complete for the sql driver!
> > 
> > There are two issues I ran into, one I know how to fix and the other I
> don't
> > so 
> > I'll just mention it.
> > 
> > 1) An event with a daily recurrence and a recur interval > 1 day doesn't
> show
> > 
> > up in the month view. The problem lead me to the daily recurrences
> > calculation -
> >  nextRecurrence() in sql.php, case KRONOLITH_RECUR_DAILY - and I'm pretty
> > sure 
> > it's not being done correctly.
> > 
> > To fix it, line 230 of sql.php should use the ceil() function instead of
> the
> > 
> > floor() function.
> > 
> > current: 
> > $recur = (floor($diff->mday / $event->recurInterval)) *
> > $event->recurInterval;
> > 
> > fix:
> > $recur = (ceil($diff->mday / $event->recurInterval)) *
> > $event->recurInterval;
> > 
> > The calculation with floor() correctly returns the next recurrence date
> only
> > 
> > when the passed date ($afterDate) is the next recurrence date which is why
> it
> > 
> > shows up correctly in the summary, day, and week views and not in the
> month
> > 
> > view unless the recur interval is 1 day. It fails in the month view for
> the
> > 
> > following reason:
> > 
> > If the event startdate is 10/2/2001 and the recurInterval is 2 (days), 
> > month.php first calls nextRecurrence() passing it 10/3/2001. based on the
> > above 
> > calculation using floor(), $recur equals 0 when it should be 2.
> > 
> > I looked at a lot of examples and I'm pretty sure that the calculation
> using
> > 
> > ceil() correctly returns the next recurrence after the passed date
> > ($afterDate).
> > 
> > After changing it, you can test it and it should show up correctly in all
> 
> > views. BUT make sure your start time isn't equal to 12:00AM due to the
> next
> > 
> > issue.
> > 
> > 
> > 2) Daily and weekly recurrences display properly (with the above change)
> > except 
> > when the event start time is 12AM. This is a problem whether you make the
> > above 
> > change or not.
> > 
> > To see this, create an event with a daily recurrence repeating every 3 or
> > more 
> > days and a start time of 12AM. You'll see in the summary, daily, and
> weekly
> > 
> > views that the event and it's recurrences also show up on the previous
> days.
> > 
> > The month view is fine.
> > 
> > So it's some kind of boundary issue with 12AM. I think nextRecurrence() is
> 
> > incorrectly being called first with the previous day.
> > 
> > Thanks,
> > Jesse 
> > 
> > -- 
> > Kronolith mailing list: http://horde.org/kronolith/
> > Frequently Asked Questions: http://horde.org/faq/
> > To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> > 
> 
> 
> 
> -- 
> Kronolith mailing list: http://horde.org/kronolith/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> 
> 


:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From wolff@yahoo.com Date: Tue,  2 Oct 2001 02:59:43 -0700
Return-Path: <jesse_wolff@yahoo.com>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 98470 invoked from network); 2 Oct 2001 09:53:41 -0000
Received: from adsl-63-196-6-8.dsl.snfc21.pacbell.net (HELO tiny.crankybear.com) (63.196.6.8)
  by clark.horde.org with SMTP; 2 Oct 2001 09:53:41 -0000
Received: (from nobody@localhost)
	by tiny.crankybear.com (8.11.6/8.11.2) id f929xl319346
	for kronolith@lists.horde.org; Tue, 2 Oct 2001 02:59:47 -0700
X-Authentication-Warning: tiny.crankybear.com: nobody set sender to jesse_wolff@yahoo.com using -f
Received: from 192.168.10.2 ( [192.168.10.2])
	as user jesse@localhost by www.crankybear.com with HTTP;
	Tue,  2 Oct 2001 02:59:43 -0700
Message-ID: <1002016783.3bb9900fb82ab@www.crankybear.com>
Date: Tue,  2 Oct 2001 02:59:43 -0700
From: Jesse Wolff <jesse_wolff@yahoo.com>
To: kronolith@lists.horde.org
References: <1001927457.3bb8332142fae@www.crankybear.com> <1001980209.3bb901319fc0d@www.crankybear.com> <1002013401.3bb982d94acf8@jan.dip.ammma.net>
In-Reply-To: <1002013401.3bb982d94acf8@jan.dip.ammma.net>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] daily recurrence calculation - sql driver

Thanks.

Yes, my head does hurt but it's going to hurt worse when we try to get multiday 
working with recurrences...

I'm just happy that very soon I'll be able to start using kronolith instead of 
lookOut.

Jesse.

Quoting Jan Schneider <jan@horde.org>:

> Many thanks for this nice catch and patch.
> 
> As you probably realized the recurrence calculation can make you some
> headaches 
> and I'm glad that someone dives into the code and tries to fix the issues.
> 
> I still want to test your patches (also the multiday) as soon as I have the
> 
> time but I want you to know that I'm very happy about your work.
> 
> Jan.
> 
> Zitat von Jesse Wolff <jesse_wolff@yahoo.com>:
> 
> > Hi.
> > 
> > Attached is a patch to fix both of the issues I mentioned. They both occur
> in
> > 
> > sql.php so they won't adversely affect mcal.
> > 
> > I tested it with a bunch of cases so recurrences should show up correctly
> now
> > 
> > in all of the views no matter what the start time, except of course the 
> > Monthly:Same weekday recurrence which isn't yet implemented for the sql
> > driver.
> > 
> > There's still an issue with the times for recurrences and multi-day events
> in
> > 
> > the summary view but I'll send through another patch for that.
> > 
> > Jesse.
> > 
> > Index: lib/Driver/sql.php
> > ===================================================================
> > RCS file: /repository/kronolith/lib/Driver/sql.php,v
> > retrieving revision 1.19
> > diff -r1.19 sql.php
> > 128c128
> > <                     if ($next && Kronolith::compareDates($next,
> $endDate)
> > <= 0
> > ) {
> > ---
> > >                     if ($next && Kronolith::compareDates($next, $endDate)
> <
> > 0)
> >  {
> > 230c230
> > <             $recur = (floor($diff->mday / $event->recurInterval)) *
> > $event->re
> > curInterval;
> > ---
> > >             $recur = (ceil($diff->mday / $event->recurInterval)) *
> > $event->rec
> > urInterval;
> > 
> > 
> > 
> > Quoting Jesse Wolff <jesse_wolff@yahoo.com>:
> > 
> > > Hi.
> > > 
> > > I updated to the latest cvs tonight and noticed that recurrences are
> > almost
> > > 
> > > complete for the sql driver!
> > > 
> > > There are two issues I ran into, one I know how to fix and the other I
> > don't
> > > so 
> > > I'll just mention it.
> > > 
> > > 1) An event with a daily recurrence and a recur interval > 1 day
> doesn't
> > show
> > > 
> > > up in the month view. The problem lead me to the daily recurrences
> > > calculation -
> > >  nextRecurrence() in sql.php, case KRONOLITH_RECUR_DAILY - and I'm
> pretty
> > > sure 
> > > it's not being done correctly.
> > > 
> > > To fix it, line 230 of sql.php should use the ceil() function instead
> of
> > the
> > > 
> > > floor() function.
> > > 
> > > current: 
> > > $recur = (floor($diff->mday / $event->recurInterval)) *
> > > $event->recurInterval;
> > > 
> > > fix:
> > > $recur = (ceil($diff->mday / $event->recurInterval)) *
> > > $event->recurInterval;
> > > 
> > > The calculation with floor() correctly returns the next recurrence date
> > only
> > > 
> > > when the passed date ($afterDate) is the next recurrence date which is
> why
> > it
> > > 
> > > shows up correctly in the summary, day, and week views and not in the
> > month
> > > 
> > > view unless the recur interval is 1 day. It fails in the month view for
> > the
> > > 
> > > following reason:
> > > 
> > > If the event startdate is 10/2/2001 and the recurInterval is 2 (days), 
> > > month.php first calls nextRecurrence() passing it 10/3/2001. based on
> the
> > > above 
> > > calculation using floor(), $recur equals 0 when it should be 2.
> > > 
> > > I looked at a lot of examples and I'm pretty sure that the calculation
> > using
> > > 
> > > ceil() correctly returns the next recurrence after the passed date
> > > ($afterDate).
> > > 
> > > After changing it, you can test it and it should show up correctly in
> all
> > 
> > > views. BUT make sure your start time isn't equal to 12:00AM due to the
> > next
> > > 
> > > issue.
> > > 
> > > 
> > > 2) Daily and weekly recurrences display properly (with the above
> change)
> > > except 
> > > when the event start time is 12AM. This is a problem whether you make
> the
> > > above 
> > > change or not.
> > > 
> > > To see this, create an event with a daily recurrence repeating every 3
> or
> > > more 
> > > days and a start time of 12AM. You'll see in the summary, daily, and
> > weekly
> > > 
> > > views that the event and it's recurrences also show up on the previous
> > days.
> > > 
> > > The month view is fine.
> > > 
> > > So it's some kind of boundary issue with 12AM. I think nextRecurrence()
> is
> > 
> > > incorrectly being called first with the previous day.
> > > 
> > > Thanks,
> > > Jesse 
> > > 
> > > -- 
> > > Kronolith mailing list: http://horde.org/kronolith/
> > > Frequently Asked Questions: http://horde.org/faq/
> > > To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> > > 
> > 
> > 
> > 
> > -- 
> > Kronolith mailing list: http://horde.org/kronolith/
> > Frequently Asked Questions: http://horde.org/faq/
> > To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> > 
> > 
> 
> 
> :::::::::::::::::::::::::::::::::::::::: 
> AMMMa AG - discover your knowledge
> :::::::::::::::::::::::::::
> Detmolder Str. 25-33 :: D-33604 Bielefeld
> fon +49.521.96878-0 :: fax  +49.521.96878-20
> http://www.ammma.de
> ::::::::::::::::::::::::::::::::::::::::::::::
> 
> -- 
> Kronolith mailing list: http://horde.org/kronolith/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> 




>From jan@horde.org Date: Fri,  5 Oct 2001 01:18:27 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 62311 invoked from network); 4 Oct 2001 23:24:20 -0000
Received: from mailout04.sul.t-online.com (HELO mailout04.sul.t-online.de) (194.25.134.18)
  by clark.horde.org with SMTP; 4 Oct 2001 23:24:20 -0000
Received: from fwd06.sul.t-online.de 
	by mailout04.sul.t-online.de with smtp 
	id 15pHql-0008Hh-02; Fri, 05 Oct 2001 01:24:19 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.25]) by fmrl06.sul.t-online.com
	with esmtp id 15pHqb-09L6zwC; Fri, 5 Oct 2001 01:24:09 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f94NISc19871
	for <kronolith@lists.horde.org>; Fri, 5 Oct 2001 01:18:28 +0200
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@mail.wg.de by linux.wg.de with HTTP;
	Fri,  5 Oct 2001 01:18:27 +0200
Message-ID: <1002237507.3bbcee437fdbe@linux.wg.de>
Date: Fri,  5 Oct 2001 01:18:27 +0200
From: Jan Schneider <jan@horde.org>
To: kronolith@lists.horde.org
References: <1001984023.3bb9101705f1f@www.crankybear.com>
In-Reply-To: <1001984023.3bb9101705f1f@www.crankybear.com>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [kronolith] sql driver patch - multiday events

Zitat von Jesse Wolff <jesse_wolff@yahoo.com>:

> 1) The times for recurrence events don't show correctly when the recurrence
> 
> start date is greater than the current time.
> 
> This problem is due to the second part of the if statement on line 33-34:
> 
> if (!$event->hasRecurType(KRONOLITH_RECUR_NONE) &&
>                  $event->startTimestamp < $now) {
> 
> I can't find a reason why this check is necessary for the sql driver and it
> 
> causes the above problem. If mcal doesn't need it as well we can take it out

It took my some time to remember why we used this line and I think it was a 
really dirty hack to test for recurrence. Anyway, removing the second test 
works well with mcal so it's gone now.

> 2) The times for multi-day events don't show up correctly.
> 
> This is due to line 44:
> 
> $event->endTimestamp = $event->startTimestamp + $event->durMin * 60;
> 
> For the sql driver it shouldn't be included. If it's not needed by mcal it
> can 
> be deleted. If it's needed by mcal it will need to be wrapped by a check for

This has just been in the wrong line. It should recalculate the event end if we 
recalculated the event start because of recurrence.

All fixed now in cvs.

Thanks again,
Jan.

:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jan@horde.org Date: Fri,  5 Oct 2001 01:24:09 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 62860 invoked from network); 4 Oct 2001 23:34:10 -0000
Received: from mailout01.sul.t-online.com (HELO mailout01.sul.t-online.de) (194.25.134.80)
  by clark.horde.org with SMTP; 4 Oct 2001 23:34:10 -0000
Received: from fwd07.sul.t-online.de 
	by mailout01.sul.t-online.de with smtp 
	id 15pI0G-00071t-01; Fri, 05 Oct 2001 01:34:08 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.25]) by fmrl07.sul.t-online.com
	with esmtp id 15pI09-1g4BYuC; Fri, 5 Oct 2001 01:34:01 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f94NO9c19905
	for <kronolith@lists.horde.org>; Fri, 5 Oct 2001 01:24:10 +0200
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@mail.wg.de by linux.wg.de with HTTP;
	Fri,  5 Oct 2001 01:24:09 +0200
Message-ID: <1002237849.3bbcef997617e@linux.wg.de>
Date: Fri,  5 Oct 2001 01:24:09 +0200
From: Jan Schneider <jan@horde.org>
To: kronolith@lists.horde.org
References: <1001485094.3bb1732673d94@webmail.lauwerscollege.nl> <1001519063.3bb1f7d74e623@linux.wg.de> <1001522446.3bb2050e88f75@webmail.lauwerscollege.nl> <1001530642.3bb22512beb00@linux.wg.de> <1001579392.3bb2e3800f5c0@webmail.lauwerscollege.nl> <1001580346.3bb2e73a448e1@linux.wg.de> <1001589530.3bb30b1aeb80c@webmail.lauwerscollege.nl> <1001590511.3bb30eef70802@linux.wg.de> <1001592777.3bb317c9c9d73@webmail.lauwerscollege.nl> <1001598065.3bb32c7204d4a@webmail.lauwerscollege.nl> <1001603269.3bb340c55a86f@linux.wg.de> <1001659298.3bb41ba25a5a2@webmail.lauwerscollege.nl> <1001662772.3bb42934d7e7e@linux.wg.de> <1001676880.3bb4605073d79@webmail.lauwerscollege.nl> <1001677916.3bb4645cb348e@jan.dip.ammma.net> <1001678736.3bb46790e1580@webmail.lauwerscollege.nl> <1001687171.3bb4888345038@marina.horde.org> <1001687850.3bb48b2a4cbed@jan.dip.ammma.net> <1001919818.3bb8154ae64b3@webmail.lauwerscollege.nl>
In-Reply-To: <1001919818.3bb8154ae64b3@webmail.lauwerscollege.nl>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [kronolith] Error exporting events

I put the IE quirk code to the place where Chuck suggested.
Please try again.

Jan.

Zitat von Jan Kuipers <jrkuipers@lauwerscollege.nl>:

> Citeren Jan Schneider <jan@horde.org>:
> 
> > OK, I added this to kronlith's data.php.
> > 
> > Jan, please give it another try.
> 
> Still doesn't work :(
> 
> -- 
> Jan Kuipers,
> Systeembeheer Lauwers College
> 
> -- 
> Kronolith mailing list: http://horde.org/kronolith/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> 
> 


:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jrkuipers@lauwerscollege.nl Date: Fri,  5 Oct 2001 09:14:58 +0200
Return-Path: <jrkuipers@lauwerscollege.nl>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 70784 invoked from network); 5 Oct 2001 07:15:29 -0000
Received: from c3207.upc-c.chello.nl (HELO linux.lauwerscollege.nl) (212.187.3.207)
  by clark.horde.org with SMTP; 5 Oct 2001 07:15:29 -0000
Received: (from www@localhost)
	by linux.lauwerscollege.nl (8.11.6/8.8.7) id f957Ewn15126
	for kronolith@lists.horde.org; Fri, 5 Oct 2001 09:14:58 +0200
Received: from 212.187.3.207 ( [212.187.3.207])
	as user jrkuipers@localhost by webmail.lauwerscollege.nl with HTTP;
	Fri,  5 Oct 2001 09:14:58 +0200
Message-ID: <1002266098.3bbd5df22841e@webmail.lauwerscollege.nl>
Date: Fri,  5 Oct 2001 09:14:58 +0200
From: Jan Kuipers <jrkuipers@lauwerscollege.nl>
To: kronolith@lists.horde.org
References: <1001485094.3bb1732673d94@webmail.lauwerscollege.nl> <1001519063.3bb1f7d74e623@linux.wg.de> <1001522446.3bb2050e88f75@webmail.lauwerscollege.nl> <1001530642.3bb22512beb00@linux.wg.de> <1001579392.3bb2e3800f5c0@webmail.lauwerscollege.nl> <1001580346.3bb2e73a448e1@linux.wg.de> <1001589530.3bb30b1aeb80c@webmail.lauwerscollege.nl> <1001590511.3bb30eef70802@linux.wg.de> <1001592777.3bb317c9c9d73@webmail.lauwerscollege.nl> <1001598065.3bb32c7204d4a@webmail.lauwerscollege.nl> <1001603269.3bb340c55a86f@linux.wg.de> <1001659298.3bb41ba25a5a2@webmail.lauwerscollege.nl> <1001662772.3bb42934d7e7e@linux.wg.de> <1001676880.3bb4605073d79@webmail.lauwerscollege.nl> <1001677916.3bb4645cb348e@jan.dip.ammma.net> <1001678736.3bb46790e1580@webmail.lauwerscollege.nl> <1001687171.3bb4888345038@marina.horde.org> <1001687850.3bb48b2a4cbed@jan.dip.ammma.net> <1001919818.3bb8154ae64b3@webmail.lauwerscollege.nl> <1002237849.3bbcef997617e@linux.wg.de>
In-Reply-To: <1002237849.3bbcef997617e@linux.wg.de>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] Error exporting events

Citeren Jan Schneider <jan@horde.org>:

> I put the IE quirk code to the place where Chuck suggested.
> Please try again.

That did it! It works now for IE5 and NN-4.7x, but Opera 5.01 echoes still to 
the screen. Thanks sofar, Jan.

-- 
Jan Kuipers,
Systeembeheer Lauwers College


>From wolff@yahoo.com Date: Fri,  5 Oct 2001 03:01:47 -0700
Return-Path: <jesse_wolff@yahoo.com>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 73810 invoked from network); 5 Oct 2001 09:55:31 -0000
Received: from adsl-66-124-233-11.dsl.snfc21.pacbell.net (HELO tiny.crankybear.com) (66.124.233.11)
  by clark.horde.org with SMTP; 5 Oct 2001 09:55:31 -0000
Received: (from nobody@localhost)
	by tiny.crankybear.com (8.11.6/8.11.2) id f95A1nw26326
	for kronolith@lists.horde.org; Fri, 5 Oct 2001 03:01:49 -0700
X-Authentication-Warning: tiny.crankybear.com: nobody set sender to jesse_wolff@yahoo.com using -f
Received: from 192.168.10.2 ( [192.168.10.2])
	as user jesse@localhost by mail.crankybear.com with HTTP;
	Fri,  5 Oct 2001 03:01:47 -0700
Message-ID: <1002276107.3bbd850b2d021@mail.crankybear.com>
Date: Fri,  5 Oct 2001 03:01:47 -0700
From: Jesse Wolff <jesse_wolff@yahoo.com>
To: kronolith@lists.horde.org
References: <1001984023.3bb9101705f1f@www.crankybear.com> <1002237507.3bbcee437fdbe@linux.wg.de>
In-Reply-To: <1002237507.3bbcee437fdbe@linux.wg.de>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] sql driver patch - multiday events

Good, I'm glad you didn't have to put in any driver specific checks since I'm 
sure you want to keep it abstracted outside of sql.php and mcal.php.

Jesse.

Quoting Jan Schneider <jan@horde.org>:

> Zitat von Jesse Wolff <jesse_wolff@yahoo.com>:
> 
> > 1) The times for recurrence events don't show correctly when the
> recurrence
> > 
> > start date is greater than the current time.
> > 
> > This problem is due to the second part of the if statement on line 33-34:
> > 
> > if (!$event->hasRecurType(KRONOLITH_RECUR_NONE) &&
> >                  $event->startTimestamp < $now) {
> > 
> > I can't find a reason why this check is necessary for the sql driver and
> it
> > 
> > causes the above problem. If mcal doesn't need it as well we can take it
> out
> 
> It took my some time to remember why we used this line and I think it was a
> 
> really dirty hack to test for recurrence. Anyway, removing the second test 
> works well with mcal so it's gone now.
> 
> > 2) The times for multi-day events don't show up correctly.
> > 
> > This is due to line 44:
> > 
> > $event->endTimestamp = $event->startTimestamp + $event->durMin * 60;
> > 
> > For the sql driver it shouldn't be included. If it's not needed by mcal
> it
> > can 
> > be deleted. If it's needed by mcal it will need to be wrapped by a check
> for
> 
> This has just been in the wrong line. It should recalculate the event end if
> we 
> recalculated the event start because of recurrence.
> 
> All fixed now in cvs.
> 
> Thanks again,
> Jan.
> 
> :::::::::::::::::::::::::::::::::::::::: 
> AMMMa AG - discover your knowledge
> :::::::::::::::::::::::::::
> Detmolder Str. 25-33 :: D-33604 Bielefeld
> fon +49.521.96878-0 :: fax  +49.521.96878-20
> http://www.ammma.de
> ::::::::::::::::::::::::::::::::::::::::::::::
> 
> -- 
> Kronolith mailing list: http://horde.org/kronolith/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> 




>From jan@horde.org Date: Fri,  5 Oct 2001 12:13:45 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 74468 invoked from network); 5 Oct 2001 10:14:20 -0000
Received: from mailout03.sul.t-online.com (HELO mailout03.sul.t-online.de) (194.25.134.81)
  by clark.horde.org with SMTP; 5 Oct 2001 10:14:20 -0000
Received: from fwd01.sul.t-online.de 
	by mailout03.sul.t-online.de with smtp 
	id 15pRzm-0007Ol-03; Fri, 05 Oct 2001 12:14:18 +0200
Received: from linux.wg.de (320034214675-0001@[217.80.111.25]) by fmrl01.sul.t-online.com
	with esmtp id 15pRzR-26oKTQC; Fri, 5 Oct 2001 12:13:57 +0200
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id f95ADkc21387
	for <kronolith@lists.horde.org>; Fri, 5 Oct 2001 12:13:46 +0200
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@mail.wg.de by linux.wg.de with HTTP;
	Fri,  5 Oct 2001 12:13:45 +0200
Message-ID: <1002276825.3bbd87d97d6ae@linux.wg.de>
Date: Fri,  5 Oct 2001 12:13:45 +0200
From: Jan Schneider <jan@horde.org>
To: kronolith@lists.horde.org
References: <1001485094.3bb1732673d94@webmail.lauwerscollege.nl> <1001519063.3bb1f7d74e623@linux.wg.de> <1001522446.3bb2050e88f75@webmail.lauwerscollege.nl> <1001530642.3bb22512beb00@linux.wg.de> <1001579392.3bb2e3800f5c0@webmail.lauwerscollege.nl> <1001580346.3bb2e73a448e1@linux.wg.de> <1001589530.3bb30b1aeb80c@webmail.lauwerscollege.nl> <1001590511.3bb30eef70802@linux.wg.de> <1001592777.3bb317c9c9d73@webmail.lauwerscollege.nl> <1001598065.3bb32c7204d4a@webmail.lauwerscollege.nl> <1001603269.3bb340c55a86f@linux.wg.de> <1001659298.3bb41ba25a5a2@webmail.lauwerscollege.nl> <1001662772.3bb42934d7e7e@linux.wg.de> <1001676880.3bb4605073d79@webmail.lauwerscollege.nl> <1001677916.3bb4645cb348e@jan.dip.ammma.net> <1001678736.3bb46790e1580@webmail.lauwerscollege.nl> <1001687171.3bb4888345038@marina.horde.org> <1001687850.3bb48b2a4cbed@jan.dip.ammma.net> <1001919818.3bb8154ae64b3@webmail.lauwerscollege.nl> <1002237849.3bbcef997617e@linux.wg.de> <1002266098.3bbd5df22841e@webmail.lauwer!
 scollege.nl>
In-Reply-To: <1002266098.3bbd5df22841e@webmail.lauwerscollege.nl>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [kronolith] Error exporting events

I just tested with Opera 5.02 and it worked perfect. Could try to update Opera 
and perhaps check if this only happens with the ssl version?

Jan.

Zitat von Jan Kuipers <jrkuipers@lauwerscollege.nl>:

> Citeren Jan Schneider <jan@horde.org>:
> 
> > I put the IE quirk code to the place where Chuck suggested.
> > Please try again.
> 
> That did it! It works now for IE5 and NN-4.7x, but Opera 5.01 echoes still to
> 
> the screen. Thanks sofar, Jan.
> 
> -- 
> Jan Kuipers,
> Systeembeheer Lauwers College
> 
> -- 
> Kronolith mailing list: http://horde.org/kronolith/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: kronolith-unsubscribe@lists.horde.org
> 
> 


:::::::::::::::::::::::::::::::::::::::: 
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jrkuipers@lauwerscollege.nl Date: Fri,  5 Oct 2001 13:24:04 +0200
Return-Path: <jrkuipers@lauwerscollege.nl>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 76699 invoked from network); 5 Oct 2001 11:24:35 -0000
Received: from c3207.upc-c.chello.nl (HELO linux.lauwerscollege.nl) (212.187.3.207)
  by clark.horde.org with SMTP; 5 Oct 2001 11:24:35 -0000
Received: (from www@localhost)
	by linux.lauwerscollege.nl (8.11.6/8.8.7) id f95BO4U16921
	for kronolith@lists.horde.org; Fri, 5 Oct 2001 13:24:04 +0200
Received: from 212.187.3.207 ( [212.187.3.207])
	as user jrkuipers@localhost by webmail.lauwerscollege.nl with HTTP;
	Fri,  5 Oct 2001 13:24:04 +0200
Message-ID: <1002281044.3bbd98540c806@webmail.lauwerscollege.nl>
Date: Fri,  5 Oct 2001 13:24:04 +0200
From: Jan Kuipers <jrkuipers@lauwerscollege.nl>
To: kronolith@lists.horde.org
References: <1001485094.3bb1732673d94@webmail.lauwerscollege.nl> <1001519063.3bb1f7d74e623@linux.wg.de> <1001522446.3bb2050e88f75@webmail.lauwerscollege.nl> <1001530642.3bb22512beb00@linux.wg.de> <1001579392.3bb2e3800f5c0@webmail.lauwerscollege.nl> <1001580346.3bb2e73a448e1@linux.wg.de> <1001589530.3bb30b1aeb80c@webmail.lauwerscollege.nl> <1001590511.3bb30eef70802@linux.wg.de> <1001592777.3bb317c9c9d73@webmail.lauwerscollege.nl> <1001598065.3bb32c7204d4a@webmail.lauwerscollege.nl> <1001603269.3bb340c55a86f@linux.wg.de> <1001659298.3bb41ba25a5a2@webmail.lauwerscollege.nl> <1001662772.3bb42934d7e7e@linux.wg.de> <1001676880.3bb4605073d79@webmail.lauwerscollege.nl> <1001677916.3bb4645cb348e@jan.dip.ammma.net> <1001678736.3bb46790e1580@webmail.lauwerscollege.nl> <1001687171.3bb4888345038@marina.horde.org> <1001687850.3bb48b2a4cbed@jan.dip.ammma.net> <1001919818.3bb8154ae64b3@webmail.lauwerscollege.nl> <1002237849.3bbcef997617e@linux.wg.de> <1002266098.3bbd5df22841e@webmail.lauwer!
 ! scollege.nl> <1002276825.3bbd87d97d6ae@linux.wg.de>
In-Reply-To: <1002276825.3bbd87d97d6ae@linux.wg.de>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] Error exporting events

Citeren Jan Schneider <jan@horde.org>:

> I just tested with Opera 5.02 and it worked perfect. Could try to update
> Opera 
> and perhaps check if this only happens with the ssl version?

I updated Opera to 5.12 for Windows and 5.05 TP1 for Linux. But both versions keep echoing to the screen with both http and https links.
It's probably something stupid overhere, but I don't see it (yet).

-- 
Jan Kuipers,
Systeembeheer Lauwers College


>From jrkuipers@lauwerscollege.nl Date: Fri,  5 Oct 2001 13:31:47 +0200
Return-Path: <jrkuipers@lauwerscollege.nl>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 76918 invoked from network); 5 Oct 2001 11:32:18 -0000
Received: from c3207.upc-c.chello.nl (HELO linux.lauwerscollege.nl) (212.187.3.207)
  by clark.horde.org with SMTP; 5 Oct 2001 11:32:18 -0000
Received: (from www@localhost)
	by linux.lauwerscollege.nl (8.11.6/8.8.7) id f95BVlJ16969
	for kronolith@lists.horde.org; Fri, 5 Oct 2001 13:31:47 +0200
Received: from 212.187.3.207 ( [212.187.3.207])
	as user jrkuipers@localhost by webmail.lauwerscollege.nl with HTTP;
	Fri,  5 Oct 2001 13:31:47 +0200
Message-ID: <1002281507.3bbd9a2317a2a@webmail.lauwerscollege.nl>
Date: Fri,  5 Oct 2001 13:31:47 +0200
From: Jan Kuipers <jrkuipers@lauwerscollege.nl>
To: kronolith@lists.horde.org
References: <1001485094.3bb1732673d94@webmail.lauwerscollege.nl> <1001519063.3bb1f7d74e623@linux.wg.de> <1001522446.3bb2050e88f75@webmail.lauwerscollege.nl> <1001530642.3bb22512beb00@linux.wg.de> <1001579392.3bb2e3800f5c0@webmail.lauwerscollege.nl> <1001580346.3bb2e73a448e1@linux.wg.de> <1001589530.3bb30b1aeb80c@webmail.lauwerscollege.nl> <1001590511.3bb30eef70802@linux.wg.de> <1001592777.3bb317c9c9d73@webmail.lauwerscollege.nl> <1001598065.3bb32c7204d4a@webmail.lauwerscollege.nl> <1001603269.3bb340c55a86f@linux.wg.de> <1001659298.3bb41ba25a5a2@webmail.lauwerscollege.nl> <1001662772.3bb42934d7e7e@linux.wg.de> <1001676880.3bb4605073d79@webmail.lauwerscollege.nl> <1001677916.3bb4645cb348e@jan.dip.ammma.net> <1001678736.3bb46790e1580@webmail.lauwerscollege.nl> <1001687171.3bb4888345038@marina.horde.org> <1001687850.3bb48b2a4cbed@jan.dip.ammma.net> <1001919818.3bb8154ae64b3@webmail.lauwerscollege.nl> <1002237849.3bbcef997617e@linux.wg.de> <1002266098.3bbd5df22841e@webmail.lauwer!
 ! ! scollege.nl> <1002276825.3bbd87d97d6ae@linux.wg.de> <1002281044.3bbd98540c806@webmail.lauwerscollege.nl>
In-Reply-To: <1002281044.3bbd98540c806@webmail.lauwerscollege.nl>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] Error exporting events

Citeren Jan Kuipers <jrkuipers@lauwerscollege.nl>:

> Citeren Jan Schneider <jan@horde.org>:
> 
> > I just tested with Opera 5.02 and it worked perfect. Could try to update
> > Opera 
> > and perhaps check if this only happens with the ssl version?
> 
> I updated Opera to 5.12 for Windows and 5.05 TP1 for Linux. But both versions
> keep echoing to the screen with both http and https links.
> It's probably something stupid overhere, but I don't see it (yet).

As I said: something stupid. I changed the mime handling for this mime-type in Opera and now it works fine :)

-- 
Jan Kuipers,
Systeembeheer Lauwers College


>From chuck@horde.org Date: Fri,  5 Oct 2001 10:26:22 -0400
Return-Path: <chuck@horde.org>
Mailing-List: contact kronolith-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list kronolith@lists.horde.org
Received: (qmail 82761 invoked from network); 5 Oct 2001 14:26:57 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.198.7)
  by clark.horde.org with SMTP; 5 Oct 2001 14:26:57 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 9C5B53CE2; Fri,  5 Oct 2001 10:26:22 -0400 (EDT)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@localhost by marina.horde.org with HTTP;
	Fri,  5 Oct 2001 10:26:22 -0400
Message-ID: <1002291982.3bbdc30e734a7@marina.horde.org>
Date: Fri,  5 Oct 2001 10:26:22 -0400
From: Chuck Hagenbuch <chuck@horde.org>
To: kronolith@lists.horde.org
References: <1001984023.3bb9101705f1f@www.crankybear.com> <1002237507.3bbcee437fdbe@linux.wg.de> <1002276107.3bbd850b2d021@mail.crankybear.com>
In-Reply-To: <1002276107.3bbd850b2d021@mail.crankybear.com>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [kronolith] sql driver patch - multiday events

Quoting Jesse Wolff <jesse_wolff@yahoo.com>:

> Good, I'm glad you didn't have to put in any driver specific checks since I'm 
> sure you want to keep it abstracted outside of sql.php and mcal.php.

Yes, the API should definitely stay abstract enough that people can implement 
it with whatever backend they want to use...

-chuck

--
"There is a river of blood between them." - A member of RAWA 
(http://www.rawa.org) on the difference between the people of Afghanistan and 
the criminal government of Afghanistan.